From: Samuel Ortiz <samuel@sortiz.org>
To: "John W. Linville" <linville@tuxdriver.com>
Cc: linux-wireless@vger.kernel.org,
Alina Friedrichsen <x-alina@gmx.net>,
Kalle Valo <kalle.valo@iki.fi>,
Larry Finger <Larry.Finger@lwfinger.net>,
Reinette Chatre <reinette.chatre@intel.com>
Subject: [PATCH] mac80211: ieee80211_sta_set_bssid should call config_interface()
Date: Fri, 23 Jan 2009 02:30:01 +0100 [thread overview]
Message-ID: <20090123013000.GA5604@sortiz.org> (raw)
From: Samuel Ortiz <samuel.ortiz@intel.com>
With commit e32b1b9a33759e8a83ac566c4c43f23ed5d6343b, we end up not calling
config_interface() when we're in STA, but not Ad-Hoc. This breaks several
drivers, and the fix is to get ieee80211_sta_set_bssid() to call
ieee80211_if_config() again.
Signed-off-by: Samuel Ortiz <samuel.ortiz@intel.com>
Signed-off-by: Reinette Chatre <reinette.chatre@intel.com>
---
net/mac80211/mlme.c | 12 ++++++++++++
1 file changed, 12 insertions(+)
Index: wireless-testing/net/mac80211/mlme.c
===================================================================
--- wireless-testing.orig/net/mac80211/mlme.c 2009-01-23 01:33:54.000000000 +0100
+++ wireless-testing/net/mac80211/mlme.c 2009-01-23 01:36:51.000000000 +0100
@@ -2650,6 +2650,18 @@ int ieee80211_sta_set_bssid(struct ieee8
ifsta->flags &= ~IEEE80211_STA_BSSID_SET;
}
+ if (netif_running(sdata->dev)) {
+ int ret;
+
+ ret = ieee80211_if_config(sdata, IEEE80211_IFCC_BSSID);
+
+ if (ret) {
+ printk(KERN_DEBUG "%s: Failed to config new BSSID to "
+ "the low-level driver\n", sdata->dev->name);
+ return ret;
+ }
+ }
+
return ieee80211_sta_set_ssid(sdata, ifsta->ssid, ifsta->ssid_len);
}
--
Intel Open Source Technology Centre
http://oss.intel.com/
next reply other threads:[~2009-01-23 1:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-23 1:30 Samuel Ortiz [this message]
2009-01-23 2:44 ` [PATCH] mac80211: ieee80211_sta_set_bssid should call config_interface() Sedat Dilek
2009-01-23 18:50 ` John W. Linville
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090123013000.GA5604@sortiz.org \
--to=samuel@sortiz.org \
--cc=Larry.Finger@lwfinger.net \
--cc=kalle.valo@iki.fi \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=reinette.chatre@intel.com \
--cc=x-alina@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.