Re: HP accelerometer driver: testers wanted

[Pavel Machek <pavel@suse.cz>]

On Fri 2009-01-23 09:59:25, Frans Pop wrote:
> On Friday 23 January 2009, Frans Pop wrote:
> > The LED lights up yellow, but I have problems telling if the disk gets
> > parked or not. One time I got a green led and seemingly a fair amount
> > of activity immediately after getting the yellow led.
> >
> > After looking at hpfall.c, I checked /sys/block/sda/device/unload_heads
> > after a drop:
> > $ cat /sys/block/sda/device/unload_heads
> > 19616
> > $ cat /sys/block/sda/device/unload_heads
> > 0
> >
> > The last was at most 2 seconds after the first, certainly not 20...
> 
> I've just looked at hpcall.c a bit closer and I guess that's because of 
> the alarm(2) call? I must admit having some problems reading that
> code.

Yes, it works as designed. Change if (1 || into if (0) and you'll get
20 second timeouts.

(It initially asks for 20 seconds to give itself time for those other
calculations.)
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html