From: Daniele Venzano <venza@brownhat.org>
To: kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] Fix warning in aty128fb
Date: Fri, 23 Jan 2009 10:39:35 +0000 [thread overview]
Message-ID: <20090123103935.GA31264@milesteg.arr> (raw)
In-Reply-To: <20090120161859.GA31365@milesteg.arr>
I changed the patch to not define backlight only in case the driver is
compiled as module. Now it compiles both statically or as module without
errors or warnings.
Patch is against 2.6.28.1
Signed-off-by: Daniele Venzano <venza@brownhat.org>
--- linux-2.6.28.1/drivers/video/aty/aty128fb.c.old 2009-01-20 16:08:06.000000000 +0100
+++ linux-2.6.28.1/drivers/video/aty/aty128fb.c 2009-01-23 11:34:16.000000000 +0100
@@ -360,8 +360,10 @@ static int mtrr = 1;
#ifdef CONFIG_PMAC_BACKLIGHT
static int backlight __devinitdata = 1;
#else
+#ifndef MODULE
static int backlight __devinitdata = 0;
#endif
+#endif
/* PLL constants */
struct aty128_constants {
next prev parent reply other threads:[~2009-01-23 10:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-20 16:18 [PATCH] Fix warning in aty128fb Daniele Venzano
2009-01-23 10:02 ` Richard Genoud
2009-01-23 10:39 ` Daniele Venzano [this message]
2009-01-23 13:20 ` Richard Genoud
2009-01-23 15:56 ` Richard Genoud
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090123103935.GA31264@milesteg.arr \
--to=venza@brownhat.org \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.