From: Nanako Shiraishi <nanako3@lavabit.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git list <git@vger.kernel.org>,
Christian MICHON <christian.michon@gmail.com>
Subject: Re: how to force a commit date matching info from a mbox ?
Date: Fri, 23 Jan 2009 18:52:09 +0900 [thread overview]
Message-ID: <20090123185209.6117@nanako3.lavabit.com> (raw)
In-Reply-To: 20090123172646.6117@nanako3.lavabit.com
Quoting Junio C Hamano <gitster@pobox.com>:
>> --->8---
>> Subject: [PATCH] git-am: Add --ignore-date option
>
> Good.
>
> Leaving "Subject: " in saves me typing, because I do not have to insert it
> manually when editing the submitted patch in my MUA to chop off everything
> before the scissors.
I am sorry to ask you a stupid question, but do you mean you want to have
"Subject: " there, or do you mean you want me to leave that word out?
> I think it would work equally well if you somehow manage to pass this
> through "git-rebase", but this won't work with "git-rebase --interactive".
I can try to change git-rebase if you want, but I do not think I can
modify git-rebase --interactive. The script looked very scary last time I
looked at it (^_^;;;).
>> +test_expect_success 'am --ignore-date' '
>> + git checkout first &&
>> + test_tick &&
>> + git am --ignore-date patch1 &&
>> + git cat-file commit HEAD | sed -e "/^$/q" >head1 &&
>> + at=$(sed -ne "/^author /s/.*> //p" head1) &&
>> + echo "$at" | grep "+0000"
>> +'
>
> This is a convoluted logic.
>
> The committer and author dates are set to -0700 timezone by test_tick,
> while TZ is set to UTC (+0000) by test-lib.sh, and you are taking
> advantage of them to see which one is being used.
>
> But I do not think of a better way to do this offhand, so I'll let it
> pass.
>
> Regarding the "date -R" thing, I think we can take advantage of the fact
> that an empty GIT_AUTHOR_DATE (and GIT_COMMITTER_DATE) means "do not use
> this environment variable, but use the current date instead". Something
> like this patch on top of yours, whose first hunk reverts your change to
> use "date -R", and sets GIT_AUTHOR_DATE to empty when --ignore-date is
> asked for.
>
> No, I didn't test it.
I did, and it works.
Thank you very much.
--
Nanako Shiraishi
http://ivory.ap.teacup.com/nanako3/
next prev parent reply other threads:[~2009-01-23 9:54 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-22 22:41 how to force a commit date matching info from a mbox ? Christian MICHON
2009-01-23 0:14 ` Junio C Hamano
2009-01-23 0:45 ` Nanako Shiraishi
2009-01-23 7:37 ` Junio C Hamano
2009-01-23 8:26 ` Nanako Shiraishi
2009-01-23 9:39 ` Junio C Hamano
2009-01-23 22:29 ` Jeff King
2009-01-24 0:34 ` Johannes Schindelin
2009-01-24 0:52 ` Jeff King
2009-01-24 1:43 ` Johannes Schindelin
2009-01-24 2:35 ` Jeff King
2009-01-23 9:52 ` Nanako Shiraishi [this message]
2009-01-23 17:27 ` Junio C Hamano
2009-01-23 12:38 ` [PATCH] git-am: Add --ignore-date option Johannes Schindelin
2009-01-23 13:17 ` Adeodato Simó
2009-01-23 8:08 ` how to force a commit date matching info from a mbox ? Christian MICHON
2009-01-23 8:51 ` Christian MICHON
2009-01-23 0:21 ` Johannes Schindelin
2009-01-23 8:07 ` Christian MICHON
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090123185209.6117@nanako3.lavabit.com \
--to=nanako3@lavabit.com \
--cc=christian.michon@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.