All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Felipe Balbi <me@felipebalbi.com>
Cc: Felipe Balbi <felipe.balbi@nokia.com>,
	ext Kalle Valo <kalle.valo@nokia.com>,
	linux-omap@vger.kernel.org
Subject: Re: [PATCH 3/3] Disable linux-omap version of menelaus
Date: Fri, 23 Jan 2009 11:23:25 -0800	[thread overview]
Message-ID: <20090123192323.GX7172@atomide.com> (raw)
In-Reply-To: <20090123192144.GZ440@frodo>

* Felipe Balbi <me@felipebalbi.com> [090123 11:22]:
> On Thu, Jan 22, 2009 at 06:23:34PM -0800, Tony Lindgren wrote:
> > * Felipe Balbi <felipe.balbi@nokia.com> [090122 05:27]:
> > > On Thu, Jan 22, 2009 at 03:19:20PM +0200, Kalle Valo wrote:
> > > > Fixes linker errors like this:
> > > > 
> > > > drivers/i2c/built-in.o: In function `menelaus_set_vdcdc':
> > > > lp5521.c:(.text+0x3910): multiple definition of `menelaus_set_vdcdc'
> > > > drivers/mfd/built-in.o:menelaus.c:(.text+0x95c): first defined here
> > > > drivers/i2c/built-in.o: In function `menelaus_set_vio':
> > > > lp5521.c:(.text+0x3990): multiple definition of `menelaus_set_vio'
> > > > 
> > > > Signed-off-by: Kalle Valo <kalle.valo@nokia.com>
> > > > ---
> > > > 
> > > >  drivers/i2c/chips/Makefile |    1 -
> > > >  1 files changed, 0 insertions(+), 1 deletions(-)
> > > > 
> > > > diff --git a/drivers/i2c/chips/Makefile b/drivers/i2c/chips/Makefile
> > > > index b451369..d8bef8c 100644
> > > > --- a/drivers/i2c/chips/Makefile
> > > > +++ b/drivers/i2c/chips/Makefile
> > > > @@ -18,7 +18,6 @@ obj-$(CONFIG_SENSORS_PCA9539)	+= pca9539.o
> > > >  obj-$(CONFIG_SENSORS_PCF8574)	+= pcf8574.o
> > > >  obj-$(CONFIG_PCF8575)		+= pcf8575.o
> > > >  obj-$(CONFIG_SENSORS_PCF8591)	+= pcf8591.o
> > > > -obj-$(CONFIG_MENELAUS)		+= menelaus.o
> > 
> > I'll also remove drivers/i2c/chips/menelaus.c.
> 
> why, did this driver make its way to mainline with a different name then
> ??
> 
> Where did Jean move it ?

Dave has been busy again.. 88e75cc347f66bc20e3c2b920431fc07253d69be.

Tony

  reply	other threads:[~2009-01-23 19:23 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-22 13:18 [PATCH 0/3] Hacks to make Nokia N800 compile Kalle Valo
2009-01-22 13:19 ` [PATCH 1/3] n800-bt: include board-nokia.h Kalle Valo
2009-01-23  2:10   ` Tony Lindgren
2009-01-22 13:19 ` [PATCH 2/3] tsub6010: fix omap compile Kalle Valo
2009-01-23  2:10   ` Tony Lindgren
2009-01-23 12:14     ` Felipe Balbi
2009-01-23 14:04       ` Kalle Valo
2009-01-23 13:57         ` Felipe Balbi
2009-01-22 13:19 ` [PATCH 3/3] Disable linux-omap version of menelaus Kalle Valo
2009-01-22 13:15   ` Felipe Balbi
2009-01-23  2:23     ` Tony Lindgren
2009-01-23 19:21       ` Felipe Balbi
2009-01-23 19:23         ` Tony Lindgren [this message]
2009-01-23 19:27           ` Felipe Balbi
2009-01-26 11:35       ` Kalle Valo
2009-01-26 21:40         ` David Brownell
2009-01-26 21:52           ` Tony Lindgren
2009-01-26 23:17             ` David Brownell
2009-01-26 23:19               ` Felipe Balbi
2009-01-26 23:27                 ` Tony Lindgren
2009-01-26 23:31                   ` Felipe Balbi
2009-01-22 20:53 ` [PATCH 0/3] Hacks to make Nokia N800 compile green

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090123192323.GX7172@atomide.com \
    --to=tony@atomide.com \
    --cc=felipe.balbi@nokia.com \
    --cc=kalle.valo@nokia.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=me@felipebalbi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.