From: Nick Piggin <nickpiggin@yahoo.com.au>
To: Pekka Enberg <penberg@cs.helsinki.fi>
Cc: Christoph Lameter <cl@linux-foundation.org>,
yanmin_zhang@linux.intel.com, Andi Kleen <andi@firstfloor.org>,
Matthew Wilcox <matthew@wil.cx>,
linux-kernel@vger.kernel.org, akpm@linux-foundation.org
Subject: Re: [PATCH] SLUB: revert direct page allocator pass through
Date: Sat, 24 Jan 2009 02:54:00 +1100 [thread overview]
Message-ID: <200901240254.01552.nickpiggin@yahoo.com.au> (raw)
In-Reply-To: <1232725468.6094.97.camel@penberg-laptop>
On Saturday 24 January 2009 02:44:28 Pekka Enberg wrote:
> On Sat, 2009-01-24 at 02:37 +1100, Nick Piggin wrote:
> > However, I don't know if netperf udp 4K over loopback is totally
> > realistic. Maybe real network drivers have different allocation patterns.
> > If I were you I wouldn't be too hasty to make big changes based on that
> > alone, if it could introduce regression in somewhere more important.
>
> Yup, I'm putting it in linux-next to see if anything pops up. It's of
> course possible that it will introduce regression somewhere but seeing
> the hit SLUB is taking from the page allocator, I'm bound to think that
> performance increase claims of commit
> aadb4bc4a1f9108c1d0fbd121827c936c2ed4217 ("SLUB: direct pass through of
> page size or higher kmalloc requests") don't hold anymore.
Well what workload were they relating to? That could easily be retested.
next prev parent reply other threads:[~2009-01-23 15:54 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-23 8:43 [PATCH] SLUB: revert direct page allocator pass through Pekka J Enberg
2009-01-23 8:52 ` Nick Piggin
2009-01-23 9:04 ` Pekka Enberg
2009-01-23 15:03 ` Christoph Lameter
2009-01-23 15:12 ` Nick Piggin
2009-01-23 15:27 ` Christoph Lameter
2009-01-23 15:37 ` Nick Piggin
2009-01-23 15:44 ` Pekka Enberg
2009-01-23 15:54 ` Nick Piggin [this message]
2009-01-23 16:07 ` Pekka Enberg
2009-01-23 15:57 ` Christoph Lameter
2009-01-23 16:03 ` Pekka Enberg
2009-01-24 3:11 ` Zhang, Yanmin
2009-01-23 15:16 ` Pekka Enberg
2009-01-23 15:25 ` Christoph Lameter
2009-01-23 15:41 ` Nick Piggin
2009-01-23 15:59 ` Christoph Lameter
2009-01-23 16:17 ` Nick Piggin
2009-01-26 17:17 ` Christoph Lameter
2009-02-03 1:33 ` Nick Piggin
2009-02-03 17:08 ` Christoph Lameter
2009-01-23 15:42 ` Pekka Enberg
2009-01-23 20:12 ` Matt Mackall
2009-01-23 9:22 ` Zhang, Yanmin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200901240254.01552.nickpiggin@yahoo.com.au \
--to=nickpiggin@yahoo.com.au \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=cl@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew@wil.cx \
--cc=penberg@cs.helsinki.fi \
--cc=yanmin_zhang@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.