All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bob Copeland <me@bobcopeland.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] mac80211: change workqueue back to non-freezeable
Date: Sat, 24 Jan 2009 09:46:31 -0500	[thread overview]
Message-ID: <20090124144630.GA14662@hash.localnet> (raw)
In-Reply-To: <1232806437.4036.5.camel@johannes.local>

> Good catch! Do we have to freeze the workqueue ourselves manually or
> something, to avoid drivers adding work to it?

Yeah I guess so - it would only matter if they add work in one
of the callbacks we use to remove keys, interfaces, etc.   This
might be a good case for the in_suspend flag.  Or, we could just 
flush the workqueue again at the end of suspend to make sure 
nothing was added.

The other thing I don't get is why STR works fine but STD hangs,
from my reading of stuff in kernel/power they should be the same
with respect to order of task-freeze and suspend.  

-- 
Bob Copeland %% www.bobcopeland.com


  reply	other threads:[~2009-01-24 14:48 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-24  4:12 [PATCH] mac80211: change workqueue back to non-freezeable Bob Copeland
2009-01-24 14:13 ` Johannes Berg
2009-01-24 14:46   ` Bob Copeland [this message]
2009-01-24 14:52     ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090124144630.GA14662@hash.localnet \
    --to=me@bobcopeland.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.