All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hans-Christian Egtvedt <hans-christian.egtvedt@atmel.com>
To: buildroot@busybox.net
Subject: [Buildroot] Error encountered while doing make after adding u-boot
Date: Mon, 26 Jan 2009 15:30:34 +0100	[thread overview]
Message-ID: <20090126153034.21798ced@hcegtvedt> (raw)
In-Reply-To: <87skn687sf.fsf@macbook.be.48ers.dk>

On Mon, 26 Jan 2009 15:24:16 +0100
Peter Korsgaard <jacmet@uclibc.org> wrote:

> >>>>> "Hans-Christian" == Hans-Christian Egtvedt
> >>>>> <hans-christian.egtvedt@atmel.com> writes:
> 
>  >> This BOARD_NAME variable seems to be an ARM/Atmel specific thing.
>  >> 
> 
>  Hans-Christian> You can not default to $(PROJECT), since this
>  Hans-Christian> variable is used to load a configuration for u-boot
>  Hans-Christian> build system and must exist.
> 
> But you can default to $(BOARD_NAME) which isn't set for most people?
> 
> PROJECT atleast has a chance of being something close to what the user
> wants.
> 

Perhaps, but...

>  Hans-Christian> Perhaps default to a known to work config? Take a
>  Hans-Christian> peak in u-boot source ./Makefile.
> 
> Naah, to much work as that's arch dependent. Then I would rather add a
> big fat $(error) in the U-Boot Makefile.in if the thing evaluates to
> nothing.
> 

... I think checking for an empty config name is better, and print an
appropriate message before quiting. If the PROJECT happens to work,
that still might not be the u-boot config the user wants, and he/she
does not understand why u-boot does not work afterwards.

And in most instances the PROJECT name will not match a U-Boot config.

-- 
Best regards,
Hans-Christian Egtvedt

  reply	other threads:[~2009-01-26 14:30 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-26 13:06 [Buildroot] Error encountered while doing make after adding u-boot Mitesh Gupta
2009-01-26 13:40 ` Hans-Christian Egtvedt
2009-01-26 14:02   ` Peter Korsgaard
2009-01-26 14:17     ` Hans-Christian Egtvedt
2009-01-26 14:24       ` Peter Korsgaard
2009-01-26 14:30         ` Hans-Christian Egtvedt [this message]
2009-01-26 14:50           ` Peter Korsgaard
2009-01-27  0:24     ` Ulf Samuelsson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090126153034.21798ced@hcegtvedt \
    --to=hans-christian.egtvedt@atmel.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.