From: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>
To: Christoph Hellwig <hch@lst.de>
Cc: "H. Peter Anvin" <hpa@zytor.com>,
linux-kernel@vger.kernel.org, Alan Cox <alan@lxorguk.ukuu.org.uk>
Subject: Re: devpts multiple instances feedback
Date: Mon, 26 Jan 2009 19:32:11 -0800 [thread overview]
Message-ID: <20090127033211.GA13552@us.ibm.com> (raw)
In-Reply-To: <20090126215321.GA20726@lst.de>
Christoph Hellwig [hch@lst.de] wrote:
| On Sat, Jan 03, 2009 at 05:15:44PM +0100, Christoph Hellwig wrote:
| > This is a little untested patch to massage the mount code into about
| > how it should look like:
|
| ping?
I was waiting for discussion on the other thread. But yes, this does
simplify the code by copying in the common code in get_sb_single() and
get_sb_nodev() into devpts, and eliminating the do_remount() stuff in
'single-mount' mode.
We may also be able to define an "empty" mknod_ptmx() when
CONFIG_DEVPTS_MULTIPLE_INSTANCES=n and share a bit more code, but will
defer that to a separate patch.
Will test this out some more and resend the modified patch.
Sukadev
next prev parent reply other threads:[~2009-01-27 3:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-03 15:52 devpts multiple instances feedback Christoph Hellwig
2009-01-03 16:15 ` Christoph Hellwig
2009-01-26 21:53 ` Christoph Hellwig
2009-01-27 3:32 ` Sukadev Bhattiprolu [this message]
2009-01-05 21:09 ` Sukadev Bhattiprolu
2009-01-26 21:55 ` Christoph Hellwig
2009-01-26 21:58 ` Alan Cox
2009-02-01 16:29 ` Christoph Hellwig
2009-02-01 16:41 ` Alan Cox
2009-01-26 21:58 ` H. Peter Anvin
2009-02-01 16:31 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090127033211.GA13552@us.ibm.com \
--to=sukadev@linux.vnet.ibm.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=hch@lst.de \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.