From: Stephen Hemminger <shemminger@vyatta.com>
To: David Miller <davem@davemloft.net>
Cc: rdreier@cisco.com, aluno3@poczta.onet.pl,
general@lists.openfabrics.org, netdev@vger.kernel.org
Subject: Re: [ofa-general] NetEffect, iw_nes and kernel warning
Date: Tue, 27 Jan 2009 16:17:09 -0800 [thread overview]
Message-ID: <20090127161709.25072f82@extreme> (raw)
In-Reply-To: <20090127.160750.120120703.davem@davemloft.net>
On Tue, 27 Jan 2009 16:07:50 -0800 (PST)
David Miller <davem@davemloft.net> wrote:
> From: Roland Dreier <rdreier@cisco.com>
> Date: Tue, 27 Jan 2009 15:53:16 -0800
>
> > but actually I still don't see how it's safe for a net driver to
> > call skb_linearize() from its transmit routine, since there's a
> > chance that that will unconditionally enable BHs?
>
> It's simply not allowed.
>
> dev_queue_xmit() at a higher level can do __skb_linearize()
> because it does so before doing the rcu_read_lock_bh().
If the device driver can't handle non-linear SKB's then it should
not set NETIF_F_SG.
next prev parent reply other threads:[~2009-01-28 0:17 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <497EF9AC.70104@poczta.onet.pl>
2009-01-27 23:53 ` [ofa-general] NetEffect, iw_nes and kernel warning Roland Dreier
2009-01-28 0:07 ` David Miller
2009-01-28 0:17 ` Stephen Hemminger [this message]
2009-01-28 16:36 ` Tung, Chien Tin
2009-01-28 18:05 ` Roland Dreier
2009-01-28 19:05 ` Stephen Hemminger
2009-01-28 21:52 ` Roland Dreier
2009-01-30 6:57 ` Herbert Xu
2009-01-30 8:22 ` Eilon Greenstein
2009-01-30 16:25 ` Stephen Hemminger
2009-01-30 17:35 ` Roland Dreier
2009-01-30 21:51 ` David Miller
2009-01-31 3:54 ` Roland Dreier
2009-04-21 9:09 ` Lennert Buytenhek
2009-04-21 12:49 ` Herbert Xu
2009-04-21 12:50 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090127161709.25072f82@extreme \
--to=shemminger@vyatta.com \
--cc=aluno3@poczta.onet.pl \
--cc=davem@davemloft.net \
--cc=general@lists.openfabrics.org \
--cc=netdev@vger.kernel.org \
--cc=rdreier@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.