All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Grazvydas Ignotas <notasas@gmail.com>
Cc: Adrian Hunter <ext-adrian.hunter@nokia.com>,
	"drzeus-mmc@drzeus.cx" <drzeus-mmc@drzeus.cx>,
	"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"Jarkko Lavinen (NMP/Helsinki)" <jarkko.lavinen@nokia.com>
Subject: Re: [PATCH] OMAP HSMMC: fix MMC3 dma
Date: Tue, 27 Jan 2009 09:13:09 -0800	[thread overview]
Message-ID: <20090127171306.GC32148@atomide.com> (raw)
In-Reply-To: <6ed0b2680901270900t24838c73l3aa8edca62c91710@mail.gmail.com>

* Grazvydas Ignotas <notasas@gmail.com> [090127 09:00]:
> On Tue, Jan 27, 2009 at 2:02 PM, Adrian Hunter
> <ext-adrian.hunter@nokia.com> wrote:
> > Grazvydas Ignotas wrote:
> >>
> >> Data transfers on third OMAP3 MMC controller don't work
> >> because DMA line numbers are only defined for MMC1 and MMC2.
> >> Fix that and store line numbers in mmc_omap_host structure
> >> to reduce code size.
> >> Tested on OMAP3 pandora board.
> >>
> >> Signed-off-by: Grazvydas Ignotas <notasas@gmail.com>
> >> ---
> >>  drivers/mmc/host/omap_hsmmc.c |   31 +++++++++++++++++++++++--------
> >>  1 files changed, 23 insertions(+), 8 deletions(-)
> >>
> >
> > Have you considered using the scatter-gather emulation patch:
> >
> >        http://marc.info/?l=linux-omap&m=122726069922195&w=2
> >
> > It was reverted:
> >
> >        http://marc.info/?l=linux-omap&m=122904725322787&w=2
> >
> > because of a hardware problem with OMAP3430 before ES3.0, but applying:
> >
> >
> >  http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=6a79e391df295bd7c2aa1309ea5031f361c197fd
> >
> > seems to overcome even that.
> 
> Hmm, but it still doesn't know about MMC3. But in case that SG patch
> goes first, I can resend.

On related news, looks like the hsmmc.c has finally hit the mainline
tree!

Tony

  reply	other threads:[~2009-01-27 17:13 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-27 10:36 [PATCH] OMAP HSMMC: fix MMC3 dma Grazvydas Ignotas
2009-01-27 12:02 ` Adrian Hunter
2009-01-27 17:00   ` Grazvydas Ignotas
2009-01-27 17:13     ` Tony Lindgren [this message]
2009-01-28  8:35     ` Adrian Hunter
2009-02-08 19:10 ` David Brownell
2009-02-08 19:10   ` David Brownell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090127171306.GC32148@atomide.com \
    --to=tony@atomide.com \
    --cc=drzeus-mmc@drzeus.cx \
    --cc=ext-adrian.hunter@nokia.com \
    --cc=jarkko.lavinen@nokia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=notasas@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.