From: Vitaliy Gusev <vgusev@openvz.org>
To: Ayaz Abdulla <aabdulla@nvidia.com>
Cc: Manfred Spraul <manfred@colorfullife.com>,
Jeff Garzik <jgarzik@pobox.com>, Andrew Morton <akpm@osdl.org>,
nedev <netdev@vger.kernel.org>
Subject: Re: [PATCH 3/4] forcedeth: napi schedule lock fix
Date: Tue, 27 Jan 2009 19:28:16 +0300 [thread overview]
Message-ID: <200901271928.16783.vgusev@openvz.org> (raw)
In-Reply-To: <4967BBB5.9080803@nvidia.com>
On 10 January 2009 00:03:49 Ayaz Abdulla wrote:
> This patch fixes a potential race condition between scheduling napi and
> completing napi poll. The call to netif_rx_schedule should be under
> protection of the lock (as is the completion), otherwise, interrupts
> could be masked off.
Can you explain how this issue or race can occur (interrupts can be masked off) ?
netif_rx_schedule() merely mark soft irq as waked on current CPU. So dev->poll
will not be called until irq_exit() or local_bh_enable. As nv_nic_irq() is run
under interrupt context, so napi poll will be called only during irq_exit.
>
> Signed-off-by: Ayaz Abdulla <aabdulla@nvidia.com>
>
>
--
Thank,
Vitaliy Gusev
prev parent reply other threads:[~2009-01-27 16:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-09 21:03 [PATCH 3/4] forcedeth: napi schedule lock fix Ayaz Abdulla
2009-01-10 7:13 ` David Miller
2009-01-27 16:28 ` Vitaliy Gusev [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200901271928.16783.vgusev@openvz.org \
--to=vgusev@openvz.org \
--cc=aabdulla@nvidia.com \
--cc=akpm@osdl.org \
--cc=jgarzik@pobox.com \
--cc=manfred@colorfullife.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.