Re: asoc: s3c24xx+uda1380 - some questions

From: Vasily Khoruzhick <anarsoul@gmail.com>
To: Mark Brown <broonie@sirena.org.uk>
Cc: alsa-devel@alsa-project.org, pHilipp Zabel <philipp.zabel@gmail.com>
Subject: Re: asoc: s3c24xx+uda1380 - some questions
Date: Tue, 27 Jan 2009 22:14:36 +0200	[thread overview]
Message-ID: <200901272214.45021.anarsoul@gmail.com> (raw)
In-Reply-To: <20090127200051.GA6424@sirena.org.uk>

[-- Attachment #1.1: Type: text/plain, Size: 1332 bytes --]

On 27 January 2009 22:00:52 Mark Brown wrote:
> On Tue, Jan 27, 2009 at 06:22:25PM +0200, Vasily Khoruzhick wrote:
> > Btw, on rx1950 there're 4 gpio pins involved:
> > GPJ0 controls codec power
> > GPA1 controls amplifier power
> > GPG12 is jack sense pin, it's value depends whether headphone jack is
> > inserted
>
> You might want to have a look at the jack reporting API that was
> recently added, it should save you a bit of code:
>
> 	http://git.kernel.org/?p=linux/kernel/git/broonie/sound-2.6.git;a=commit;h
>=8a2cd6180f8fa00111843c2f4a4f4361995358e0
>
> It'll need a little helper for GPIOs adding to the core but that should
> be reusable.

Ok, thanks for advice

> Hrm.  The completion makes this look more like it could use a full blown
> regulator - it's certainly a pattern that will get reused often enough.

It's commented out, I don't use completions anymore.

> > 	/* configure some gpios */
> > 	s3c2410_gpio_cfgpin(S3C2410_GPD0, S3C2410_GPIO_OUTPUT);
> > 	s3c2410_gpio_cfgpin(S3C2410_GPG12, S3C2410_GPIO_IRQ);
> > 	s3c2410_gpio_cfgpin(S3C2440_GPJ0, S3C2410_GPIO_OUTPUT);
>
> The S3C24xx now supports gpiolib so you should be able to use that - the
> platform specific GPIO API will probably get killed at some point.

Yep, but s3c24xx gpiolib doesn't support all gpio pins, especially port J :)

Regards
Vasily

[-- Attachment #1.2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 197 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel