From: Christoph Hellwig <hch@infradead.org>
To: Jing Huang <huangj@brocade.com>
Cc: James.Bottomley@HansenPartnership.com, kgudipat@brocade.com,
linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org,
rvadivel@brocade.com, vravindr@brocade.com
Subject: Re: [PATCH 2/5] bfa: Brocade BFA FC SCSI driver submission
Date: Tue, 27 Jan 2009 17:16:18 -0500 [thread overview]
Message-ID: <20090127221618.GA26480@infradead.org> (raw)
In-Reply-To: <200901271854.n0RIs73a026759@swe37.brocade.com>
On Tue, Jan 27, 2009 at 10:54:07AM -0800, Jing Huang wrote:
> +/**
> + * Generic HAL callback element.
> + */
> +struct bfa_cb_qe_s {
> + struct bfa_q_s qe;
> + bfa_cb_cbfn_t cbfn;
> + bfa_boolean_t once;
> + u32 rsvd;
> + void *cbarg;
> +};
> +
> +#define bfa_cb_queue(__bfa, __hcb_qe, __cbfn, __cbarg) do { \
> + (__hcb_qe)->cbfn = (__cbfn); \
> + (__hcb_qe)->cbarg = (__cbarg); \
> + bfa_q_enq(&(__bfa)->comp_q, (__hcb_qe)); \
> +} while (0)
Please stop here, weird HALs and own list management routines are not
things we put into the tree. (except for gregs junk subdirectory..)
Please rewrite this into a proper Linux driver.
next prev parent reply other threads:[~2009-01-27 22:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-27 18:54 [PATCH 2/5] bfa: Brocade BFA FC SCSI driver submission Jing Huang
2009-01-27 22:16 ` Christoph Hellwig [this message]
2009-01-27 23:07 ` Jing Huang
2009-01-27 23:07 ` Jing Huang
2009-01-28 17:44 ` James Bottomley
2009-01-28 18:02 ` Jing Huang
2009-01-28 18:02 ` Jing Huang
2009-01-31 3:32 ` Greg KH
2009-02-01 19:03 ` Jing Huang
2009-02-01 19:03 ` Jing Huang
2009-02-04 22:46 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090127221618.GA26480@infradead.org \
--to=hch@infradead.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=huangj@brocade.com \
--cc=kgudipat@brocade.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=rvadivel@brocade.com \
--cc=vravindr@brocade.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.