From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1LS5pw-0007jz-LC for mharc-grub-devel@gnu.org; Wed, 28 Jan 2009 03:31:52 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LS5pv-0007iZ-13 for grub-devel@gnu.org; Wed, 28 Jan 2009 03:31:51 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LS5ps-0007hE-RD for grub-devel@gnu.org; Wed, 28 Jan 2009 03:31:49 -0500 Received: from [199.232.76.173] (port=40239 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LS5ps-0007hB-Kx for grub-devel@gnu.org; Wed, 28 Jan 2009 03:31:48 -0500 Received: from drak.ucw.cz ([212.71.128.78]:46327) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LS5ps-0007Dz-0M for grub-devel@gnu.org; Wed, 28 Jan 2009 03:31:48 -0500 Received: from Logran.cub (localhost [127.0.0.1]) by drak.ucw.cz (Postfix) with ESMTP id C0FD94B for ; Wed, 28 Jan 2009 09:31:41 +0100 (CET) Date: Wed, 28 Jan 2009 09:31:17 +0100 From: ebik To: grub-devel@gnu.org Message-ID: <20090128093117.63a94857@Logran.cub> In-Reply-To: <1233115372.2431.51.camel@dv> References: <49771040.7010509@impulze.org> <1232559057.17462.2.camel@dv> <49799320.1000300@impulze.org> <1232944909.1604.18.camel@dv> <497E00B1.3090001@impulze.org> <1233107345.8331.7.camel@dv> <1233115372.2431.51.camel@dv> X-Mailer: Claws Mail 3.5.0 (GTK+ 2.12.11; i486-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) Subject: Re: [PATCH] caseless uuid detection, fixed wrong behaviour for strncasecmp, added strcasecmp X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Jan 2009 08:31:51 -0000 On Tue, 27 Jan 2009 23:02:52 -0500 Pavel Roskin wrote: > P.S. The reuse would be impractical. fs_uuid is a separate module, > not the core. Reusing search_fs_uuid() would make the "search" module > depend on "fs_uuid". In my opinion, it's not worth the trouble to > introduce that dependency. It's not like we would save a lot of code.=20 Inlining or macro may be considered at that point. (I.e., reusing code via .h file.) If someone will try to change such function (e.g., to provide HisNewFs) then he need not to patch two places. --=20 Tom=C3=A1=C5=A1 'eb=C3=ADk' Ebenlendr http://get.to/ebik PF 2009.07504223744