From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Daniel P. Berrange" Subject: Re: [PATCH 0/3] Add date and domid to guest's console output. Date: Wed, 28 Jan 2009 11:04:48 +0000 Message-ID: <20090128110448.GJ1213@redhat.com> References: <20090128131435.107B.SHIMADA-YXB@necst.nec.co.jp> Reply-To: "Daniel P. Berrange" Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20090128131435.107B.SHIMADA-YXB@necst.nec.co.jp> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Yuji Shimada Cc: xen-devel@lists.xensource.com, Keir Fraser List-Id: xen-devel@lists.xenproject.org On Wed, Jan 28, 2009 at 01:33:12PM +0900, Yuji Shimada wrote: > These patches add date and domid to guest's console output. > > [PATCH 1/3] Add "--timestamp" option to xenconsole. > [PATCH 2/3] Add "--console_timestamp" to xm create. > [PATCH 3/3] Modify stubdom-dm. > > We can log guest's console output with date and domid when we create > the guest like below. > > # xm create -c --console_timestamp GUEST > GUEST-console.log This seems like a slightly odd place in the code to address the problem. The xenconsoled daemon has the ability to save all guest data to a logfile in /var/log/xen/console/guest-$NAME.log. So if you want to save logs and timestamp them, it'd seem more natural to put timestamping capability in the xenconsoled program. Of course this only handles paravirt console. For fullvirt guests, if you wanted to timestamp the serial console output, then something would need to be done with QEMU - or perhaps get QEMU to feed the serial data to the xenconsoled program for logging to disk ? Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|