From: Paul Brook <paul@codesourcery.com>
To: qemu-devel@nongnu.org
Cc: Glauber Costa <glommer@redhat.com>, aliguori@us.ibm.com
Subject: Re: [Qemu-devel] [PATCH] expose paravirt feature list to cpuid
Date: Wed, 28 Jan 2009 13:50:09 +0000 [thread overview]
Message-ID: <200901281350.11132.paul@codesourcery.com> (raw)
In-Reply-To: <1233145351-22380-1-git-send-email-glommer@redhat.com>
> +#ifdef KVM_CPUID_SIGNATURE
> + /* Paravirtualization CPUIDs */
> + memcpy(signature, "KVMKVMKVM\0\0\0", 12);
> + pv_ent->ebx = signature[0];
> + pv_ent->ecx = signature[1];
> + pv_ent->edx = signature[2];
This is broken on big-endian hosts.
I realise this code is currently only enabled for x86 hosts, however there's a
good chance we'll want to implement something similar for normal qemu. At
minimum it needs a comment saying that it's potentially broken.
Paul
prev parent reply other threads:[~2009-01-28 13:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-28 12:22 [Qemu-devel] [PATCH] expose paravirt feature list to cpuid Glauber Costa
2009-01-28 13:50 ` Paul Brook [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200901281350.11132.paul@codesourcery.com \
--to=paul@codesourcery.com \
--cc=aliguori@us.ibm.com \
--cc=glommer@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.