From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Subject: Re: [PATCH] parisc: don't touch driver core internals Date: Wed, 28 Jan 2009 09:35:57 -0800 Message-ID: <20090128173557.GA7583@kroah.com> References: <20090127010733.GA21660@kroah.com> <1233163519.3236.82.camel@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-parisc@vger.kernel.org, Kyle McMartin , Matthew Wilcox , Grant Grundler , Kay Sievers To: James Bottomley Return-path: In-Reply-To: <1233163519.3236.82.camel@localhost.localdomain> List-ID: List-Id: linux-parisc.vger.kernel.org On Wed, Jan 28, 2009 at 11:25:19AM -0600, James Bottomley wrote: > On Mon, 2009-01-26 at 17:07 -0800, Greg KH wrote: > > From: Greg Kroah-Hartman > > > > It isn't wise to use the struct device klists on their own, as their > > implementation has a tendancy to change at times. Instead, use the > > functions created for iterating over lists of devices, as it handles all > > of the dirty klist work for you automatically. > > > > This is needed as the driver core is changing how klists are stored in > > struct device in the near future. > > > > Cc: Kyle McMartin > > Cc: Matthew Wilcox > > Cc: Grant Grundler > > Cc: Kay Sievers > > Signed-off-by: Greg Kroah-Hartman > > > > --- > > > > I can keep this in my driver-core tree, where is it required in order > > for parisc to build properly. Or you all can take this now, in your > > tree, whatever is easier for you. > > > > drivers/char/agp/parisc-agp.c | 24 ++++++--------- > > drivers/parisc/gsc.c | 40 +++++++++++++++----------- > > drivers/parisc/sba_iommu.c | 64 ++++++++++++++++++++++++------------------ > > 3 files changed, 71 insertions(+), 57 deletions(-) > > Actually, we already have such a patch here: > > http://marc.info/?l=linux-parisc&m=123154903507114 > > The approaches look identical. Author: Greg Kroah-Hartman ??? I wrote that? heh, I forgot all about that... Yeah, that looks fine to me. thanks, greg k-h