From: "John W. Linville" <linville@tuxdriver.com>
To: Kalle Valo <kalle.valo@iki.fi>
Cc: Alina Friedrichsen <x-alina@gmx.net>,
linux-wireless@vger.kernel.org, johannes@sipsolutions.net
Subject: Re: [PATCH v2] mac80211: Creating new IBSS with fixed BSSID
Date: Wed, 28 Jan 2009 13:26:56 -0500 [thread overview]
Message-ID: <20090128182656.GA4198@tuxdriver.com> (raw)
In-Reply-To: <87k58f74dk.fsf@litku.valot.fi>
On Wed, Jan 28, 2009 at 07:00:07PM +0200, Kalle Valo wrote:
> "Alina Friedrichsen" <x-alina@gmx.net> writes:
>
> > This fixes a bug when creating a new IBSS network with a fixed BSSID. The fixed BSSID situation is now with one of my last patches handled in ieee80211_sta_find_ibss() function.
> >
> > It's more robust to test against (ifsta->flags & IEEE80211_STA_PREV_BSSID_SET), because ifsta->state is not seted right in every situation and so the creating of the new IBSS network sometimes hangs after the first try to scan for a network to merge.
>
> Please line wrap your commit logs. Now you had very long lines.
ACK, please.
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
prev parent reply other threads:[~2009-01-28 18:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-28 15:30 [PATCH v2] mac80211: Creating new IBSS with fixed BSSID Alina Friedrichsen
2009-01-28 17:00 ` Kalle Valo
2009-01-28 18:26 ` John W. Linville [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090128182656.GA4198@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=johannes@sipsolutions.net \
--cc=kalle.valo@iki.fi \
--cc=linux-wireless@vger.kernel.org \
--cc=x-alina@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.