From: Jarod Wilson <jarod@redhat.com>
To: Stefan Richter <stefanr@s5r6.in-berlin.de>
Cc: linux1394-devel@lists.sourceforge.net,
"Kristian Høgsberg" <krh@bitplanet.net>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH revised] firewire: sbp2: add workarounds for 2nd and 3rd generation iPods
Date: Wed, 28 Jan 2009 22:20:48 -0500 [thread overview]
Message-ID: <200901282220.49103.jarod@redhat.com> (raw)
In-Reply-To: <tkrat.a24a8ff6f4c5711f@s5r6.in-berlin.de>
On Wednesday 28 January 2009 18:11:59 Stefan Richter wrote:
> According to https://bugs.launchpad.net/bugs/294391
> - 3rd generation iPods need the "fix capacity" workaround after all
> (apparently they crash after the last sector was accessed),
> - 2nd generation iPods need the "128 kB maximum request size"
> workaround.
>
> Alas both iPod generations feature the same model ID in the config ROM,
> hence we can only define a shared quirks list entry for them. Luckily
> the fix capacity workaround did not show a negative effect in Jarod's
> tests with 2nd gen. iPod.
>
> A side note: Apple computers in target mode (or at least an x86 Mac
> mini) don't have firmware_version and model_id, hence none of the iPod
> quirks list entries is active for them.
>
> Tested-by: Jarod Wilson <jarod@redhat.com>
> Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
Looks golden to me, and I've wedged this into the latest Fedora rawhide
kernels. Go 'head and add this too:
Acked-by: Jarod Wilson <jarod@redhat.com>
Thanks much!
--
Jarod Wilson
jarod@redhat.com
next prev parent reply other threads:[~2009-01-29 3:21 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-24 18:41 [PATCH 0/7] ieee1394 + firewire: misc sbp2 updates Stefan Richter
2009-01-24 18:42 ` [PATCH 1/7] firewire: sbp2: fix payload limit at S1600 and S3200 Stefan Richter
2009-01-24 18:42 ` [PATCH 2/7] firewire: sbp2: define some magic numbers as macros Stefan Richter
2009-01-24 18:43 ` [PATCH 3/7] ieee1394: sbp2: fix payload limit at S1600 and S3200 Stefan Richter
2009-01-24 18:44 ` [PATCH 4/7] ieee1394: sbp2: don't assume zero model_id or firmware_revision if there is none Stefan Richter
2009-01-24 18:45 ` [PATCH 5/7] ieee1394: sbp2: follow up on "ieee1394: inherit ud vendor_id from node vendor_id" Stefan Richter
2009-01-24 18:45 ` [PATCH RFT 6/7] ieee1394: sbp2: add workarounds for 2nd and 3rd generation iPods Stefan Richter
2009-01-24 22:29 ` Stefan Richter
2009-01-24 18:46 ` [PATCH RFT 7/7] firewire: " Stefan Richter
2009-01-28 22:18 ` Jarod Wilson
2009-01-28 22:25 ` Jarod Wilson
2009-01-28 23:11 ` [PATCH revised] " Stefan Richter
2009-01-28 23:13 ` [PATCH revised] ieee1394: " Stefan Richter
2009-01-29 3:21 ` Jarod Wilson
2009-01-29 3:20 ` Jarod Wilson [this message]
2009-01-28 23:11 ` [PATCH RFT 7/7] firewire: " Stefan Richter
2009-01-29 3:18 ` Jarod Wilson
2009-01-29 20:09 ` Stefan Richter
2009-01-29 20:40 ` Alan Stern
2009-01-29 21:28 ` Stefan Richter
2009-01-29 22:38 ` Alan Stern
2009-01-30 15:16 ` Jarod Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200901282220.49103.jarod@redhat.com \
--to=jarod@redhat.com \
--cc=krh@bitplanet.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux1394-devel@lists.sourceforge.net \
--cc=stefanr@s5r6.in-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.