From: Tim Deegan <Tim.Deegan@citrix.com>
To: Jan Beulich <jbeulich@novell.com>
Cc: Gianluca Guida <gianluca.guida@eu.citrix.com>,
xen-devel@lists.xensource.com,
Keir Fraser <keir.fraser@eu.citrix.com>
Subject: Re: page ref/type count overflows
Date: Thu, 29 Jan 2009 11:07:20 +0000 [thread overview]
Message-ID: <20090129110720.GC5300@york.uk.xensource.com> (raw)
In-Reply-To: <498198E1.76E4.0078.0@novell.com>
At 10:54 +0000 on 29 Jan (1233226449), Jan Beulich wrote:
> Below is what I currently have it at. I'm afraid it won't get much simpler,
> but I think it reasonably expresses the individual overlays. There are three
> more transformations I plan to make:
> - _domain -> unsigned int
> - next_shadow -> __mfn_t
> - split u into two unions (one having type_info, type/pinned/count, and
> cpumask, the other having _domain, back, and order).
>
> That last step is to avoid having to re-add __attribute__ ((__packed__)),
> so that other (future) changes to the structure won't risk mis-aligning any
> fields again.
>
> Does this look acceptable?
Seems fine, which is to say I don't see much advantage but have no
objection. :) Please try to make it clear in the comments which fields
belong to a page which _has_ a shadow and which to a page that _is_ a
shadow.
Cheers,
Tim.
--
Tim Deegan <Tim.Deegan@citrix.com>
Principal Software Engineer, Citrix Systems (R&D) Ltd.
[Company #02300071, SL9 0DZ, UK.]
next prev parent reply other threads:[~2009-01-29 11:07 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-26 13:10 page ref/type count overflows Jan Beulich
2009-01-26 13:33 ` Keir Fraser
2009-01-26 13:51 ` Keir Fraser
2009-01-26 14:10 ` Jan Beulich
2009-01-26 14:19 ` Keir Fraser
2009-01-26 14:38 ` Jan Beulich
2009-01-26 14:54 ` Keir Fraser
2009-01-26 16:15 ` Jan Beulich
2009-01-26 16:30 ` Keir Fraser
2009-01-27 9:34 ` Tim Deegan
2009-01-26 17:01 ` Keir Fraser
2009-01-27 10:16 ` Jan Beulich
2009-01-27 10:24 ` Keir Fraser
2009-01-27 11:22 ` Keir Fraser
2009-01-27 15:38 ` Keir Fraser
2009-01-27 15:49 ` Jan Beulich
2009-01-27 16:03 ` Keir Fraser
2009-01-29 8:34 ` Jan Beulich
2009-01-29 8:45 ` Keir Fraser
2009-01-29 10:54 ` Jan Beulich
2009-01-29 11:07 ` Tim Deegan [this message]
2009-01-29 11:26 ` Keir Fraser
2009-01-29 14:04 ` Gianluca Guida
2009-01-29 10:12 ` Tim Deegan
2009-01-29 10:57 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090129110720.GC5300@york.uk.xensource.com \
--to=tim.deegan@citrix.com \
--cc=gianluca.guida@eu.citrix.com \
--cc=jbeulich@novell.com \
--cc=keir.fraser@eu.citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.