All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Risto Suominen <risto.suominen@gmail.com>,
	Alex Kern <alex.kern@gmx.de>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] atyfb: fix distorted image on PowerMacs
Date: Thu, 29 Jan 2009 20:37:56 -0800	[thread overview]
Message-ID: <20090129203756.780aba28.akpm@linux-foundation.org> (raw)
In-Reply-To: <1233286970.18767.19.camel@pasglop>

On Fri, 30 Jan 2009 14:42:50 +1100 Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote:

> On Thu, 2009-01-22 at 20:22 +0200, Risto Suominen wrote:
> > Since the complete re-write in 2.6.10, some PowerMacs (At least PowerMac 5500
> > and PowerMac G3 Beige rev A) with ATI Mach64 chip have suffered from unstable
> > columns in their framebuffer image. This seems to depend on a value (4) read
> > from PLL_EXT_CNTL register, which leads to incorrect DSP config parameters to
> > be written to the chip. This patch uses a value calculated by aty_init_pll_ct
> > instead, as a starting point.
> > 
> > Signed-off-by: Risto Suominen <Risto.Suominen@gmail.com>
> > ---
> > The testing is done on kernel version 2.6.18.
> 
> This also fixes my oooold wallstreet powerbook.
> 
> Andrew, do you mind if I include that in the powerpc tree ?

Go wild.

Please don't to forget to add 'Cc: <stable@kernel.org>' to the changelog
if you consider a backport to be appropriate.

      reply	other threads:[~2009-01-30  4:38 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-22 18:22 [PATCH] atyfb: fix distorted image on PowerMacs Risto Suominen
2009-01-22 20:12 ` Ville Syrjälä
2009-02-03 18:56   ` [Linux-fbdev-devel] " Ville Syrjälä
2009-02-03 21:06     ` Benjamin Herrenschmidt
2009-02-03 21:06       ` Benjamin Herrenschmidt
2009-01-23 14:21 ` Mikael Pettersson
2009-01-30  3:42 ` Benjamin Herrenschmidt
2009-01-30  4:37   ` Andrew Morton [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090129203756.780aba28.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=alex.kern@gmx.de \
    --cc=benh@kernel.crashing.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=risto.suominen@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.