Re: [PATCH] x86: allow 8 more cpus could be used

[Ingo Molnar <mingo@elte.hu>]

* Yinghai Lu <yinghai@kernel.org> wrote:

> Ingo Molnar wrote:
> > * Yinghai Lu <yinghai@kernel.org> wrote:
> > 
> >> Impact: fix left out MARCO
> >>
> >> X86_PC will be always enabled. so need to check if we have bigsmp 
> >> support built in before cut off more than 8 cpus.
> > 
> > ah, that's a leftover reference to X86_PC. It can now be removed, together 
> > with the Kconfig X86_PC option.
> > 
> >> -#if defined(CONFIG_X86_PC) && defined(CONFIG_X86_32)
> >> +#if defined(CONFIG_X86_PC) && !defined(CONFIG_X86_BIGSMP)
> >>  	if (def_to_bigsmp && nr_cpu_ids > 8) {
> >>  		unsigned int cpu;
> >>  		unsigned nr;
> > 
> > Could you please send a patch that removes both X86_PC and X86_BIGSMP - 
> > and removes the above cutoff code too, so that it will be built-in all the 
> > time?
> 
> sure. maybe we could keep X86_BIGSMP for a while. So someone don't 
> enable BIGSMP for small system?

yeah, we can certainly keep it - the code to conditionalize it is there 
and isnt causing problems really.

	Ingo