From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LSjLv-0002Ns-K6
	for qemu-devel@nongnu.org; Thu, 29 Jan 2009 21:43:31 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LSjLv-0002NG-0G
	for qemu-devel@nongnu.org; Thu, 29 Jan 2009 21:43:31 -0500
Received: from [199.232.76.173] (port=60366 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LSjLu-0002N6-6F
	for qemu-devel@nongnu.org; Thu, 29 Jan 2009 21:43:30 -0500
Received: from mx20.gnu.org ([199.232.41.8]:1438)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <paul@codesourcery.com>)
	id 1LSjLt-0005qO-LG
	for qemu-devel@nongnu.org; Thu, 29 Jan 2009 21:43:29 -0500
Received: from mail.codesourcery.com ([65.74.133.4])
	by mx20.gnu.org with esmtp (Exim 4.60)
	(envelope-from <paul@codesourcery.com>) id 1LSjLs-0002Oj-He
	for qemu-devel@nongnu.org; Thu, 29 Jan 2009 21:43:28 -0500
From: Paul Brook <paul@codesourcery.com>
Subject: Re: [Qemu-devel] (no subject)
Date: Fri, 30 Jan 2009 02:43:22 +0000
References: <1233258889-6878-1-git-send-email-uril@redhat.com>
In-Reply-To: <1233258889-6878-1-git-send-email-uril@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200901300243.23382.paul@codesourcery.com>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: Hello@redhat.com, Uri Lublin <uril@redhat.com>

On Thursday 29 January 2009, Uri Lublin wrote:
> The following patch fixes saving/loading/migrating a VM with
> multiple e1000 NICs.

I don't know what problems you're seeing, but this is definitely not the right 
way to fix them.

> It turns out many devices use -1 as instance (for register_savevm),
> which is wrong in cases where there can exist multiple such
> devices within a single VM.

No it isn't. -1 means automatically assign IDs, and is what everything should 
be using. The explicit ID argument is a historcal wart. Read the comment 
above register_savevm.

Paul