All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] MIPS: Fix compile warning in au1x00_eth.c
Date: Fri, 30 Jan 2009 11:22:04 +0100	[thread overview]
Message-ID: <200901301122.05028.sr@denx.de> (raw)
In-Reply-To: <4982496B.80607@necel.com>

On Friday 30 January 2009, Shinya Kuribayashi wrote:
> @@ -249,7 +249,7 @@ static int au1x00_init(struct eth_device* dev, bd_t *
> bd){ for(i=0;i<NO_OF_FIFOS;i++){
>  		fifo_tx[i].len = 0;
>  		fifo_tx[i].addr = virt_to_phys(&txbuf[0]);
> -		fifo_rx[i].addr = (virt_to_phys(NetRxPackets[i]))|RX_DMA_ENABLE;
> +		fifo_rx[i].addr = (virt_to_phys((void *)(unsigned
> long)NetRxPackets[i]))|RX_DMA_ENABLE; }
>
>  	/* Put mac addr in little endian */
>
>
> Well, what will we do?  Are there any othrer desirable fixes?

Hmmm, strange that such a double cast is really needed.

BTW: I'm beginning to wonder if we really need the "volatile" in the net 
related parameters. Perhaps this should be reviewed again.

PS: I'm leaving for a short vacation in a few hours. I'll be back on Thursday 
next week.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================

  reply	other threads:[~2009-01-30 10:22 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-28  5:44 [U-Boot] [PATCH] MIPS: Fix compile warning in au1x00_eth.c Stefan Roese
2009-01-28 14:39 ` Shinya Kuribayashi
2009-01-28 16:37   ` Stefan Roese
2009-01-30  0:27     ` Shinya Kuribayashi
2009-01-30 10:22       ` Stefan Roese [this message]
2009-02-22  5:24         ` [U-Boot] MIPS: Fix GCC-4.2 'discards qualifiers from pointer target type' warnings Shinya Kuribayashi
2009-02-22 20:16           ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200901301122.05028.sr@denx.de \
    --to=sr@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.