From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andy Whitcroft <apw@shadowen.org>
Subject: Re: [PATCH 02/35] Btrfs multi-device code
Date: Fri, 30 Jan 2009 15:09:14 +0000
Message-ID: <20090130150914.GA16400@shadowen.org>
References: <1231387045-27838-1-git-send-email-chris.mason@oracle.com> <1231387045-27838-3-git-send-email-chris.mason@oracle.com> <20090112222345.6474c79e.akpm@linux-foundation.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Chris Mason <chris.mason@oracle.com>,
	torvalds@linux-foundation.org, linux-fsdevel@vger.kernel.org
To: Andrew Morton <akpm@linux-foundation.org>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from tallyho.bytemark.co.uk ([80.68.81.166]:40359 "EHLO
	tallyho.bytemark.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751023AbZA3PgI (ORCPT
	<rfc822;linux-fsdevel@vger.kernel.org>);
	Fri, 30 Jan 2009 10:36:08 -0500
Content-Disposition: inline
In-Reply-To: <20090112222345.6474c79e.akpm@linux-foundation.org>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On Mon, Jan 12, 2009 at 10:23:45PM -0800, Andrew Morton wrote:
> On Wed,  7 Jan 2009 22:56:52 -0500 Chris Mason <chris.mason@oracle.com> wrote:
> > +	list_for_each_entry(device, &seed_devices->devices, dev_list) {
> > +		device->fs_devices = seed_devices;
> > +	}
> 
> unneeded braces
> 
> <runs checkpatch>
> 
> <checkpatch misses this - regression?>

It never did check them for the list_for_foo things.  Will add that to
my todo list.

> #2001: FILE: fs/btrfs/volumes.c:1930:
> +               return calc_size * num_stripes;
>                                  ^
> 
> ERROR: space prohibited after that '*' (ctx:WxW)
> #2072: FILE: fs/btrfs/volumes.c:2001:
> +               max_chunk_size = calc_size * 2;
>                                            ^
> 
> ERROR: space prohibited after that '*' (ctx:WxW)
> #2089: FILE: fs/btrfs/volumes.c:2018:
> +       if (calc_size * num_stripes > max_chunk_size) {
> 	                      ^
> 	
> ERROR: space prohibited after that '*' (ctx:WxW)
> #2105: FILE: fs/btrfs/volumes.c:2034:
> +               min_free = calc_size * 2;
> 	                                     ^
> 
> hm, they're all wrong.	

Ok all the * spacing errors are the same basic fault.  That there is an
else on the previous line and that is being incomporated incorrectly
into the statement for possible type analysis.  This part will be fixed
in my next block of updates.