From: "Luis R. Rodriguez" <lrodriguez@atheros.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Luis Rodriguez <Luis.Rodriguez@Atheros.com>,
Jouni Malinen <Jouni.Malinen@Atheros.com>,
"linville@tuxdriver.com" <linville@tuxdriver.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH v3] mac80211: do not TX injected frames when not allowed
Date: Fri, 30 Jan 2009 08:39:44 -0800 [thread overview]
Message-ID: <20090130163944.GC6534@tesla> (raw)
In-Reply-To: <1233313382.30970.3.camel@johannes.local>
On Fri, Jan 30, 2009 at 03:03:02AM -0800, Johannes Berg wrote:
> On Tue, 2009-01-27 at 18:50 -0800, Luis R. Rodriguez wrote:
> > Monitor mode is able to TX by using injected frames. We should
> > not allow injected frames to be sent unless allowed by regulatory
> > rules. Since AP mode uses a monitor interfaces to transmit
> > management frames we have to take care to not break AP mode as
> > well while resolving this. We deal with this by allowing compliant
> > APs solutions to inform mac80211 if their monitor interface is
> > intended to be used for an AP by setting a cfg80211 flag for the
> > monitor interface. hostapd, for example, currently does its own
> > checks to ensure AP mode is not used on channels which require radar
> > detection. Once such solutions are available it can can enable this
> > flag.
>
> > + * @NL80211_MNTR_FLAG_AP_MGT: this monitor interface is used for AP mode
> > + * to be able to inject management frames.
>
> Come to think of it, is that really a good name? The intention is "will
> check for radar" but then we don't even have a way to check for radar
> yet!
>
> So maybe we should leave that out, and introduce it with proper radar
> support later?
Dude, that's the approach I had in my first patch for this, you had suggested
to add this so I did. Anyway yeah I agree, heh. I'll send v5.
Luis
prev parent reply other threads:[~2009-01-30 16:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-28 2:50 [PATCH v3] mac80211: do not TX injected frames when not allowed Luis R. Rodriguez
2009-01-28 20:51 ` Johannes Berg
2009-01-30 11:03 ` Johannes Berg
2009-01-30 16:39 ` Luis R. Rodriguez [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090130163944.GC6534@tesla \
--to=lrodriguez@atheros.com \
--cc=Jouni.Malinen@Atheros.com \
--cc=Luis.Rodriguez@Atheros.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.