From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LSzLo-00076l-Jl
	for qemu-devel@nongnu.org; Fri, 30 Jan 2009 14:48:28 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LSzLo-00075w-3a
	for qemu-devel@nongnu.org; Fri, 30 Jan 2009 14:48:28 -0500
Received: from [199.232.76.173] (port=48785 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LSzLn-00075j-PH
	for qemu-devel@nongnu.org; Fri, 30 Jan 2009 14:48:27 -0500
Received: from hall.aurel32.net ([88.191.82.174]:37767)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <aurelien@aurel32.net>)
	id 1LSzLn-0003xk-EA
	for qemu-devel@nongnu.org; Fri, 30 Jan 2009 14:48:27 -0500
Date: Fri, 30 Jan 2009 20:48:21 +0100
From: Aurelien Jarno <aurelien@aurel32.net>
Subject: Re: [Qemu-devel] [PATCH] take2. SH: Fix struct target_stat64 for
	64bit host
Message-ID: <20090130194821.GA19283@hall.aurel32.net>
References: <48F62D38.50001@gandalf.sssup.it>
	<200810201131.m9KBV7MM024318@smtp12.dti.ne.jp>
	<200810261537.m9QFbd4n026386@smtp12.dti.ne.jp>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-15
Content-Disposition: inline
In-Reply-To: <200810261537.m9QFbd4n026386@smtp12.dti.ne.jp>
Sender: Aurelien Jarno <aurelien@aurel32.net>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Takashi YOSHII <takasi-y@ops.dti.ne.jp>
Cc: qemu-devel@nongnu.org

On Mon, Oct 27, 2008 at 12:37:39AM +0900, takasi-y@ops.dti.ne.jp wrote:
> I send fixed one, because I found (perhaps) I should send fixed patch with
>  signed-off line to be committed to the repository....
> 
> This one simply add packed attribute to the struct, as michael pointed out.
> 
> Signed-off-by: Takashi YOSHII <takasi-y@ops.dti.ne.jp>

Thanks, applied.

> ---
>  linux-user/syscall_defs.h |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/linux-user/syscall_defs.h b/linux-user/syscall_defs.h
> index 5a58010..8131905 100644
> --- a/linux-user/syscall_defs.h
> +++ b/linux-user/syscall_defs.h
> @@ -1475,7 +1475,7 @@ struct target_stat {
>  /* This matches struct stat64 in glibc2.1, hence the absolutely
>   * insane amounts of padding around dev_t's.
>   */
> -struct target_stat64 {
> +struct __attribute__((__packed__)) target_stat64 {
>  	unsigned long long	st_dev;
>  	unsigned char	__pad0[4];
>  
> -- 
> 1.5.4.3
> 
> 
> 
> 

-- 
Aurelien Jarno	                        GPG: 1024D/F1BCDB73
aurelien@aurel32.net                 http://www.aurel32.net