All of lore.kernel.org
 help / color / mirror / Atom feed
From: Aurelien Jarno <aurelien@aurel32.net>
To: Nathan Froyd <froydnj@codesourcery.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] Fix signal.c warning
Date: Fri, 30 Jan 2009 21:13:29 +0100	[thread overview]
Message-ID: <20090130201329.GA8917@volta.aurel32.net> (raw)
In-Reply-To: <1233021372-15655-1-git-send-email-froydnj@codesourcery.com>

On Mon, Jan 26, 2009 at 05:56:10PM -0800, Nathan Froyd wrote:
> This patch fixes:
> 
> /scratch/froydnj/qemu.git/linux-user/signal.c:1403: warning: no previous prototype for 'do_sigreturn_v1'
> /scratch/froydnj/qemu.git/linux-user/signal.c:1473: warning: no previous prototype for 'do_sigreturn_v2'
> /scratch/froydnj/qemu.git/linux-user/signal.c:1511: warning: no previous prototype for 'do_rt_sigreturn_v1'
> /scratch/froydnj/qemu.git/linux-user/signal.c:1552: warning: no previous prototype for 'do_rt_sigreturn_v2'
> 
> by making the appropriate functions static.
> 
> Signed-off-by: Nathan Froyd <froydnj@codesourcery.com>
> ---

Thanks, applied.

>  linux-user/signal.c |    8 ++++----
>  1 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/linux-user/signal.c b/linux-user/signal.c
> index a468d7a..b7f6f9c 100644
> --- a/linux-user/signal.c
> +++ b/linux-user/signal.c
> @@ -1399,7 +1399,7 @@ restore_sigcontext(CPUState *env, struct target_sigcontext *sc)
>  	return err;
>  }
>  
> -long do_sigreturn_v1(CPUState *env)
> +static long do_sigreturn_v1(CPUState *env)
>  {
>          abi_ulong frame_addr;
>  	struct sigframe_v1 *frame;
> @@ -1469,7 +1469,7 @@ static int do_sigframe_return_v2(CPUState *env, target_ulong frame_addr,
>      return 0;
>  }
>  
> -long do_sigreturn_v2(CPUState *env)
> +static long do_sigreturn_v2(CPUState *env)
>  {
>          abi_ulong frame_addr;
>  	struct sigframe_v2 *frame;
> @@ -1507,7 +1507,7 @@ long do_sigreturn(CPUState *env)
>      }
>  }
>  
> -long do_rt_sigreturn_v1(CPUState *env)
> +static long do_rt_sigreturn_v1(CPUState *env)
>  {
>          abi_ulong frame_addr;
>  	struct rt_sigframe_v1 *frame;
> @@ -1548,7 +1548,7 @@ badframe:
>  	return 0;
>  }
>  
> -long do_rt_sigreturn_v2(CPUState *env)
> +static long do_rt_sigreturn_v2(CPUState *env)
>  {
>          abi_ulong frame_addr;
>  	struct rt_sigframe_v2 *frame;
> -- 
> 1.6.0.5
> 
> 
> 
> 

-- 
Aurelien Jarno	                        GPG: 1024D/F1BCDB73
aurelien@aurel32.net                 http://www.aurel32.net

      reply	other threads:[~2009-01-30 20:13 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-27  1:56 [Qemu-devel] [PATCH] Fix signal.c warning Nathan Froyd
2009-01-30 20:13 ` Aurelien Jarno [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090130201329.GA8917@volta.aurel32.net \
    --to=aurelien@aurel32.net \
    --cc=froydnj@codesourcery.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.