From: Ingo Molnar <mingo@elte.hu>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: Martin Hicks <mort@sgi.com>,
tglx@linutronix.de, mingo@redhat.com, heukelum@mailshack.com,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86: push old stack address on irqstack for unwinder
Date: Sat, 31 Jan 2009 01:50:47 +0100 [thread overview]
Message-ID: <20090131005047.GA21022@elte.hu> (raw)
In-Reply-To: <49839FB6.1080509@zytor.com>
* H. Peter Anvin <hpa@zytor.com> wrote:
> Ingo Molnar wrote:
>>
>> Would be nice to have an #ifdef-less primitive for this - something like:
>>
>> pushq_frame %rbp
>>
>> and a matching:
>>
>> popq_frame %rbp
>>
>> for those cases that need it (this one doesnt as we dont pop out of the
>> stack).
>>
>
> It certainly would if this isn't a singleton, which I think it could
> possibly be?
yeah. This is pretty much the only non-restored frame we construct so
indeed it would be a singleton. Perhaps the IST ones are such ones too.
> Otherwise it really should be a part of an entry/exit macro; this is
> somewhat special in that it sets up a frame pointer as something other
> than a normal entry/exit sequence.
Sure - your call really.
Ingo
next prev parent reply other threads:[~2009-01-31 0:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-30 16:50 [PATCH] x86: push old stack address on irqstack for unwinder Martin Hicks
2009-01-30 23:37 ` H. Peter Anvin
2009-01-31 0:35 ` H. Peter Anvin
2009-01-31 0:39 ` Ingo Molnar
2009-01-31 0:47 ` H. Peter Anvin
2009-01-31 0:50 ` Ingo Molnar [this message]
2009-01-31 17:45 ` Martin Hicks
2009-02-03 5:18 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090131005047.GA21022@elte.hu \
--to=mingo@elte.hu \
--cc=heukelum@mailshack.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=mort@sgi.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.