From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Parag Warudkar <parag.lkml@gmail.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Matt Carlson <mcarlson@broadcom.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Andrew Morton <akpm@linux-foundation.org>,
Jesse Barnes <jbarnes@virtuousgeek.org>
Subject: Re: 2.6.29-rc3: tg3 dead after resume
Date: Sat, 31 Jan 2009 02:37:05 +0100 [thread overview]
Message-ID: <200901310237.06067.rjw@sisk.pl> (raw)
In-Reply-To: <alpine.DEB.2.00.0901302016170.5643@parag-desktop>
On Saturday 31 January 2009, Parag Warudkar wrote:
>
> On Sat, 31 Jan 2009, Rafael J. Wysocki wrote:
>
> > This gets more and more interesting.
> >
> > Can you test the patch below, please?
> >
> > Rafael
> >
> > ---
> > Subject: PCI PCIe portdrv: Implement pm object
> > From: Rafael J. Wysocki <rjw@sisk.pl>
> >
> > Implement pm object for the PCI Express port driver in order to use
> > the new power management framework.
> >
> > Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
> > ---
>
> Excellent! This patch works - tg3 comes back and gets link after resume.
>
> Thank you!
Great, thanks for testing.
It's in the Jesse's linux-next branch, so it should be easy to push
upstream, perhaps with a better changelog.
> Are the below differences worth worrying about - especially since post
> suspend some DevID/VendorID and some capabilities seem to be changed?
I can't tell you right now, I'm too tired. :-)
Anyway, they seem to be worth investigating.
Can you attach one of the files? That will make it easier to look at the
differences.
Thanks,
Rafael
> parag@parag-desktop:~$ diff -u lspci-pre-suspend lspci-post-fix
> --- lspci-pre-suspend 2009-01-30 18:19:50.752275695 -0500
> +++ lspci-post-fix 2009-01-30 20:14:22.605607870 -0500
> @@ -286,9 +286,9 @@
> 10: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> 20: 00 00 00 00 00 00 00 00 00 00 00 00 86 80 86 80
> 30: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> -40: 00 00 00 00 00 00 0d 00 00 00 00 00 00 00 00 00
> +40: 00 00 00 00 00 00 0f 00 00 00 00 00 00 00 00 00
> 50: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> -60: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> +60: 00 00 00 00 00 00 00 00 00 01 00 00 00 00 00 00
> 70: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> 80: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> 90: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> @@ -353,7 +353,7 @@
> 40: 00 00 00 80 14 14 b0 b0 ff 01 00 30 ff 01 00 30
> 50: 00 00 00 07 00 00 00 00 ff 3f ff 3f 00 40 00 40
> 60: 00 40 00 40 01 80 01 80 00 00 00 00 00 00 00 00
> -70: 00 00 00 00 6b e0 6b e0 00 00 0b a9 00 00 0b a9
> +70: 00 00 00 00 00 c0 00 c0 01 1b 4c b8 01 1b 4c b8
> 80: 24 07 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> 90: 01 01 08 00 01 01 08 00 01 01 08 00 01 01 08 00
> a0: 01 01 08 00 00 00 00 00 00 00 00 00 00 00 00 00
> @@ -395,7 +395,7 @@
> 40: 00 00 00 80 14 14 b0 b0 ff 01 00 30 ff 01 00 30
> 50: 00 00 00 07 00 00 00 00 ff 3f ff 3f 00 40 00 40
> 60: 00 40 00 40 01 80 01 80 00 00 00 00 00 00 00 00
> -70: 00 00 00 00 69 e0 69 e0 00 00 0b a9 00 00 0b a9
> +70: 00 00 00 00 00 40 00 40 01 1b 4c b8 01 1b 4c b8
> 80: 65 06 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> 90: 01 01 20 00 01 01 20 00 01 01 20 00 01 01 20 00
> a0: 01 01 20 00 00 00 00 00 00 00 00 00 00 00 00 00
> @@ -645,8 +645,8 @@
> 30: 00 00 00 00 50 00 00 00 00 00 00 00 03 01 00 00
> 40: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> 50: 01 58 c2 c9 00 00 00 00 0a 00 a0 20 00 00 00 00
> -60: 20 20 ff 01 00 00 00 00 01 00 00 00 00 00 08 80
> -70: 00 00 df 3f 00 00 00 00 00 00 00 00 00 00 00 00
> +60: 20 20 ff 01 00 00 00 00 01 00 00 00 00 00 08 c0
> +70: 00 00 dd 3f 00 00 00 00 00 00 00 00 00 00 00 00
> 80: 00 00 00 00 01 00 00 00 00 00 00 00 00 00 00 00
> 90: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> a0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> @@ -698,7 +698,7 @@
> 70: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> 80: 10 00 09 14 01 04 00 00 81 04 00 00 00 00 00 00
> 90: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> -a0: 10 06 00 00 01 00 00 00 00 00 00 00 00 13 00 00
> +a0: 10 06 00 00 00 00 00 00 00 00 00 00 00 13 00 00
> b0: 00 00 00 00 00 00 00 00 00 10 00 04 00 00 00 00
> c0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> d0: 33 22 11 00 67 45 00 00 c0 c0 00 00 02 00 00 00
> @@ -754,7 +754,7 @@
> Capabilities: [50] Vital Product Data <?>
> Capabilities: [58] Vendor Specific Information <?>
> Capabilities: [e8] Message Signalled Interrupts: Mask- 64bit+
> Queue=0/0 Enable+
> - Address: 00000000fee0f00c Data: 41c1
> + Address: 00000000fee0f00c Data: 41c9
> Capabilities: [d0] Express (v1) Endpoint, MSI 00
> DevCap: MaxPayload 128 bytes, PhantFunc 0, Latency L0s
> <4us, L1 unlimited
> ExtTag+ AttnBtn- AttnInd- PwrInd- RBE+ FLReset-
> @@ -778,24 +778,24 @@
> 20: 00 00 00 00 00 00 00 00 00 00 00 00 3c 10 07 13
> 30: 00 00 04 20 48 00 00 00 00 00 00 00 03 01 00 00
> 40: 00 00 00 00 00 00 00 00 01 50 03 c0 08 20 00 64
> -50: 03 58 fc 00 00 00 00 78 09 e8 78 00 95 ef 08 88
> +50: 03 58 fc 00 00 00 00 78 09 e8 78 00 9a f7 08 58
> 60: 00 00 00 00 00 00 00 00 98 02 02 a0 00 00 18 76
> 70: f2 10 00 00 c0 00 00 00 20 70 00 00 00 00 00 00
> 80: 00 00 00 00 00 00 00 00 34 00 13 04 82 70 08 fc
> -90: 19 be 00 01 00 00 00 00 00 00 00 00 94 01 00 00
> -a0: 00 00 00 00 cc 00 00 00 00 00 00 00 29 01 00 00
> -b0: 00 00 00 00 00 00 00 8e 00 00 00 00 00 00 00 00
> +90: 19 be 00 01 00 00 00 44 00 00 00 00 e7 00 00 00
> +a0: 00 00 00 00 1f 00 00 00 00 00 00 00 24 00 00 00
> +b0: 00 00 00 00 00 00 00 44 00 00 00 00 00 00 00 00
> c0: 00 00 00 00 00 00 00 00 0e 00 00 00 00 00 00 00
> d0: 10 00 01 00 a0 8f 00 00 00 50 10 00 11 64 03 00
> e0: 40 00 11 10 00 00 00 00 05 d0 81 00 0c f0 e0 fe
> -f0: 00 00 00 00 c1 41 00 00 00 00 00 00 00 00 00 00
> +f0: 00 00 00 00 c9 41 00 00 00 00 00 00 00 00 00 00
>
> 10:00.0 PCI bridge: Intel Corporation 6311ESB/6321ESB PCI Express
> Upstream Port (rev 01)
> Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop-
> ParErr- Stepping- SERR+ FastB2B- DisINTx-
> Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort-
> <TAbort- <MAbort- >SERR- <PERR- INTx-
> Latency: 0, Cache Line Size: 64 bytes
> Bus: primary=10, secondary=1e, subordinate=40, sec-latency=0
> - Secondary status: 66MHz- FastB2B- ParErr- DEVSEL=fast >TAbort-
> <TAbort- <MAbort+ <SERR- <PERR-
> + Secondary status: 66MHz- FastB2B- ParErr- DEVSEL=fast >TAbort-
> <TAbort- <MAbort- <SERR- <PERR-
> BridgeCtl: Parity- SERR+ NoISA+ VGA- MAbort- >Reset- FastB2B-
> PriDiscTmr- SecDiscTmr- DiscTmrStat- DiscTmrSERREn-
> Capabilities: [44] Express (v1) Upstream Port, MSI 00
> @@ -818,7 +818,7 @@
> Kernel driver in use: pcieport-driver
> Kernel modules: shpchp
> 00: 86 80 00 35 07 01 10 00 01 00 04 06 10 00 81 00
> -10: 00 00 00 00 00 00 00 00 10 1e 40 00 f0 00 00 20
> +10: 00 00 00 00 00 00 00 00 10 1e 40 00 f0 00 00 00
> 20: f0 ff 00 00 f1 ff 01 00 00 00 00 00 00 00 00 00
> 30: 00 00 00 00 44 00 00 00 00 00 00 00 ff 01 06 00
> 40: 00 28 02 10 10 70 51 00 01 00 00 00 0f 50 0a 00
> @@ -839,7 +839,7 @@
> Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort-
> <TAbort- <MAbort- >SERR- <PERR- INTx-
> Latency: 0, Cache Line Size: 64 bytes
> Bus: primary=10, secondary=11, subordinate=1d, sec-latency=32
> - Secondary status: 66MHz+ FastB2B+ ParErr- DEVSEL=medium >TAbort-
> <TAbort- <MAbort+ <SERR- <PERR-
> + Secondary status: 66MHz+ FastB2B+ ParErr- DEVSEL=medium >TAbort-
> <TAbort- <MAbort- <SERR- <PERR-
> BridgeCtl: Parity- SERR+ NoISA+ VGA- MAbort- >Reset- FastB2B-
> PriDiscTmr- SecDiscTmr- DiscTmrStat- DiscTmrSERREn-
> Capabilities: [44] Express (v1) PCI/PCI-X Bridge, MSI 00
> @@ -848,7 +848,7 @@
> DevCtl: Report errors: Correctable- Non-Fatal- Fatal-
> Unsupported-
> RlxdOrd- ExtTag- PhantFunc- AuxPwr- NoSnoop-
> BrConfRtry-
> MaxPayload 128 bytes, MaxReadReq 512 bytes
> - DevSta: CorrErr- UncorrErr+ FatalErr- UnsuppReq+ AuxPwr-
> TransPend-
> + DevSta: CorrErr- UncorrErr- FatalErr- UnsuppReq- AuxPwr-
> TransPend-
> LnkCap: Port #0, Speed 2.5GT/s, Width x8, ASPM L0s,
> Latency L0 unlimited, L1 unlimited
> ClockPM- Suprise- LLActRep- BwNot-
> LnkCtl: ASPM Disabled; Disabled- Retrain- CommClk-
> @@ -857,7 +857,7 @@
> Capabilities: [6c] Power Management version 2
> Flags: PMEClk- DSI- D1- D2- AuxCurrent=0mA
> PME(D0+,D1-,D2-,D3hot+,D3cold+)
> Status: D0 PME-Enable- DSel=0 DScale=0 PME-
> - Capabilities: [80] Subsystem: Hewlett-Packard Company Device 1307
> + Capabilities: [80] Subsystem: Gammagraphx, Inc. Device 0000
> Capabilities: [d8] PCI-X bridge device
> Secondary Status: 64bit+ 133MHz+ SCD- USC- SCO- SRD-
> Freq=133MHz
> Status: Dev=00:00.3 64bit- 133MHz- SCD- USC- SCO- SRD-
> @@ -866,14 +866,14 @@
> Capabilities: [100] Advanced Error Reporting <?>
> Kernel modules: shpchp
> 00: 86 80 0c 35 07 01 10 00 01 00 04 06 10 00 81 00
> -10: 00 00 00 00 00 00 00 00 10 11 1d 20 f0 00 a0 22
> +10: 00 00 00 00 00 00 00 00 10 11 1d 20 f0 00 a0 02
> 20: f0 ff 00 00 f1 ff 01 00 00 00 00 00 00 00 00 00
> 30: 00 00 00 00 44 00 00 00 00 00 00 00 00 00 06 00
> -40: 80 6e 00 ff 10 6c 71 00 01 00 00 00 00 20 0a 00
> +40: 80 6e 00 ff 10 6c 71 00 01 00 00 00 00 20 00 00
> 50: 81 f4 03 00 00 00 41 00 00 00 00 00 05 6c 80 00
> 60: 00 00 00 00 00 00 00 00 00 00 00 00 01 80 02 c8
> 70: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> -80: 0d d8 00 00 3c 10 07 13 00 00 00 00 00 00 00 00
> +80: 0d d8 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> 90: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> a0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> b0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> @@ -916,7 +916,7 @@
> 20: f0 ff 00 00 f1 ff 01 00 00 00 00 00 00 00 00 00
> 30: 00 00 00 00 44 00 00 00 00 00 00 00 00 01 06 00
> 40: 00 00 c0 00 10 60 61 00 01 00 00 00 0f 50 00 00
> -50: 41 f4 03 00 20 00 01 10 80 0c 00 00 c0 03 48 00
> +50: 41 f4 03 00 20 00 01 10 80 0c 00 00 c0 03 58 00
> 60: 05 70 81 00 0c f0 e0 fe 00 00 00 00 91 41 00 00
> 70: 01 80 02 c8 00 00 00 00 00 00 00 00 00 00 00 00
> 80: 0d 00 00 00 3c 10 07 13 00 00 00 00 00 00 00 00
> @@ -962,7 +962,7 @@
> 20: f0 ff 00 00 f1 ff 01 00 00 00 00 00 00 00 00 00
> 30: 00 00 00 00 44 00 00 00 00 00 00 00 00 01 06 00
> 40: 00 00 c0 00 10 60 61 00 01 00 00 00 0f 50 00 00
> -50: 41 f4 03 00 20 00 01 10 80 0c 00 00 c0 03 48 00
> +50: 41 f4 03 00 20 00 01 10 80 0c 00 00 c0 03 58 00
> 60: 05 70 81 00 0c f0 e0 fe 00 00 00 00 99 41 00 00
> 70: 01 80 02 c8 00 00 00 00 00 00 00 00 00 00 00 00
> 80: 0d 00 00 00 3c 10 07 13 00 00 00 00 00 00 00 00
> parag@parag-desktop:~$
next prev parent reply other threads:[~2009-01-31 1:38 UTC|newest]
Thread overview: 77+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-29 0:14 2.6.29-rc3: tg3 dead after resume Parag Warudkar
2009-01-29 1:09 ` Linus Torvalds
2009-01-29 1:49 ` Parag Warudkar
2009-01-29 2:10 ` Linus Torvalds
2009-01-29 2:19 ` Matt Carlson
2009-01-29 22:22 ` Rafael J. Wysocki
2009-01-29 18:42 ` Matt Carlson
2009-01-29 22:06 ` Parag Warudkar
2009-01-29 22:22 ` Matt Carlson
2009-01-29 22:35 ` Parag Warudkar
2009-01-29 23:10 ` Rafael J. Wysocki
2009-01-30 18:40 ` Matt Carlson
2009-01-30 22:50 ` Parag Warudkar
2009-01-30 23:06 ` Linus Torvalds
2009-01-30 23:33 ` Linus Torvalds
2009-01-30 23:45 ` Parag Warudkar
2009-01-30 23:57 ` Linus Torvalds
2009-01-30 23:59 ` Rafael J. Wysocki
2009-01-31 0:28 ` Parag Warudkar
2009-01-31 0:38 ` Rafael J. Wysocki
2009-01-31 0:44 ` Ingo Molnar
2009-01-31 0:47 ` Rafael J. Wysocki
2009-01-31 1:21 ` Parag Warudkar
2009-01-31 1:37 ` Rafael J. Wysocki [this message]
2009-01-31 1:42 ` Parag Warudkar
2009-02-03 9:29 ` Rafael J. Wysocki
2009-02-03 21:27 ` Parag Warudkar
2009-02-03 22:15 ` Rafael J. Wysocki
2009-02-03 23:50 ` WARNING: at drivers/pci/pci-driver.c:368 Parag Warudkar
2009-02-04 0:10 ` Rafael J. Wysocki
2009-02-04 0:17 ` Parag Warudkar
2009-02-04 0:19 ` Parag Warudkar
2009-02-04 0:38 ` 2.6.29-rc3: tg3 dead after resume Parag Warudkar
2009-02-04 0:41 ` Rafael J. Wysocki
2009-02-07 3:00 ` Linus Torvalds
2009-02-07 18:03 ` Jesse Barnes
2009-01-31 1:46 ` Linus Torvalds
2009-01-31 1:54 ` Parag Warudkar
2009-01-31 2:25 ` Linus Torvalds
2009-01-31 2:40 ` Parag Warudkar
2009-01-31 18:51 ` Rafael J. Wysocki
2009-01-31 2:19 ` Linus Torvalds
2009-01-31 20:45 ` Rafael J. Wysocki
2009-01-31 1:41 ` Linus Torvalds
2009-01-31 21:08 ` Rafael J. Wysocki
2009-01-31 21:42 ` What should PCI core do during suspend-resume? (was: Re: 2.6.29-rc3: tg3 dead after resume) Rafael J. Wysocki
2009-01-31 21:59 ` Linus Torvalds
2009-01-31 23:08 ` Rafael J. Wysocki
2009-01-31 23:27 ` Linus Torvalds
2009-01-31 23:39 ` Linus Torvalds
2009-02-01 0:36 ` Rafael J. Wysocki
2009-02-01 1:06 ` Linus Torvalds
2009-02-01 1:13 ` Linus Torvalds
2009-02-01 1:20 ` Arjan van de Ven
2009-02-01 1:24 ` Rafael J. Wysocki
2009-02-07 9:21 ` Pavel Machek
2009-01-31 21:47 ` 2.6.29-rc3: tg3 dead after resume Linus Torvalds
2009-01-31 22:46 ` Rafael J. Wysocki
2009-01-31 23:01 ` Linus Torvalds
2009-02-01 0:11 ` Rafael J. Wysocki
2009-02-01 0:32 ` Linus Torvalds
2009-02-01 0:41 ` Rafael J. Wysocki
2009-02-01 0:51 ` Linus Torvalds
2009-02-07 3:27 ` Benjamin Herrenschmidt
2009-02-07 3:26 ` Benjamin Herrenschmidt
2009-01-29 23:03 ` Rafael J. Wysocki
2009-01-29 23:41 ` Matt Carlson
2009-01-30 0:10 ` Rafael J. Wysocki
2009-01-30 22:31 ` Parag Warudkar
2009-01-30 22:36 ` Linus Torvalds
2009-01-30 22:54 ` Rafael J. Wysocki
2009-01-30 23:07 ` Linus Torvalds
2009-01-30 23:13 ` Parag Warudkar
2009-01-30 23:31 ` Rafael J. Wysocki
2009-01-30 23:51 ` Linus Torvalds
2009-01-31 0:07 ` Rafael J. Wysocki
2009-01-31 0:34 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200901310237.06067.rjw@sisk.pl \
--to=rjw@sisk.pl \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=jbarnes@virtuousgeek.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mcarlson@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=parag.lkml@gmail.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.