All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@suse.de>
To: linux-kernel@vger.kernel.org, stable@kernel.org
Cc: Justin Forbes <jmforbes@linuxtx.org>,
	Zwane Mwaikambo <zwane@arm.linux.org.uk>,
	"Theodore Ts'o" <tytso@mit.edu>,
	Randy Dunlap <rdunlap@xenotime.net>,
	Dave Jones <davej@redhat.com>,
	Chuck Wolber <chuckw@quantumlinux.com>,
	Chris Wedgwood <reviews@ml.cw.f00f.org>,
	Michael Krufky <mkrufky@linuxtv.org>,
	Chuck Ebbert <cebbert@redhat.com>,
	Domenico Andreoli <cavokz@gmail.com>, Willy Tarreau <w@1wt.eu>,
	Rodrigo Rubira Branco <rbranco@la.checkpoint.com>,
	Jake Edge <jake@lwn.net>, Eugene Teo <eteo@redhat.com>,
	torvalds@linux-foundation.org, akpm@linux-foundation.org,
	alan@lxorguk.ukuu.org.uk, Brandon Philips <bphilips@suse.de>,
	Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Subject: [patch 20/43] it821x: Add ultra_mask quirk for Vortex86SX
Date: Fri, 30 Jan 2009 18:42:55 -0800	[thread overview]
Message-ID: <20090131024255.GU12368@kroah.com> (raw)
In-Reply-To: <20090131024158.GA12368@kroah.com>

[-- Attachment #1: it821x-add-ultra_mask-quirk-for-vortex86sx.patch --]
[-- Type: text/plain, Size: 2380 bytes --]

2.6.28-stable review patch.  If anyone has any objections, please let us know.

------------------

From: Brandon Philips <brandon@ifup.org>

commit b94b898f3107046b5c97c556e23529283ea5eadd upstream.

On Vortex86SX with IDE controller revision 0x11 ultra DMA must be
disabled. This patch was tested by DMP and seems to work.

It is a cleaned up version of their older Kernel patch:
 http://www.dmp.com.tw/tech/vortex86sx/patch-2.6.24-DMP.gz

Tested-by: Shawn Lin <shawn@dmp.com.tw>
Signed-off-by: Brandon Philips <bphilips@suse.de>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

---
 drivers/ide/it821x.c    |   12 ++++++++++++
 include/linux/pci_ids.h |    1 +
 2 files changed, 13 insertions(+)

--- a/drivers/ide/it821x.c
+++ b/drivers/ide/it821x.c
@@ -68,6 +68,8 @@
 
 #define DRV_NAME "it821x"
 
+#define QUIRK_VORTEX86 1
+
 struct it821x_dev
 {
 	unsigned int smart:1,		/* Are we in smart raid mode */
@@ -79,6 +81,7 @@ struct it821x_dev
 	u16	pio[2];			/* Cached PIO values */
 	u16	mwdma[2];		/* Cached MWDMA values */
 	u16	udma[2];		/* Cached UDMA values (per drive) */
+	u16	quirks;
 };
 
 #define ATA_66		0
@@ -580,6 +583,12 @@ static void __devinit init_hwif_it821x(i
 
 	hwif->ultra_mask = ATA_UDMA6;
 	hwif->mwdma_mask = ATA_MWDMA2;
+
+	/* Vortex86SX quirk: prevent Ultra-DMA mode to fix BadCRC issue */
+	if (idev->quirks & QUIRK_VORTEX86) {
+		if (dev->revision == 0x11)
+			hwif->ultra_mask = 0;
+	}
 }
 
 static void it8212_disable_raid(struct pci_dev *dev)
@@ -652,6 +661,8 @@ static int __devinit it821x_init_one(str
 		return -ENOMEM;
 	}
 
+	itdevs->quirks = id->driver_data;
+
 	rc = ide_pci_init_one(dev, &it821x_chipset, itdevs);
 	if (rc)
 		kfree(itdevs);
@@ -671,6 +682,7 @@ static void __devexit it821x_remove(stru
 static const struct pci_device_id it821x_pci_tbl[] = {
 	{ PCI_VDEVICE(ITE, PCI_DEVICE_ID_ITE_8211), 0 },
 	{ PCI_VDEVICE(ITE, PCI_DEVICE_ID_ITE_8212), 0 },
+	{ PCI_VDEVICE(RDC, PCI_DEVICE_ID_RDC_D1010), QUIRK_VORTEX86 },
 	{ 0, },
 };
 
--- a/include/linux/pci_ids.h
+++ b/include/linux/pci_ids.h
@@ -2171,6 +2171,7 @@
 #define PCI_DEVICE_ID_RDC_R6040		0x6040
 #define PCI_DEVICE_ID_RDC_R6060		0x6060
 #define PCI_DEVICE_ID_RDC_R6061		0x6061
+#define PCI_DEVICE_ID_RDC_D1010		0x1010
 
 #define PCI_VENDOR_ID_LENOVO		0x17aa
 


  parent reply	other threads:[~2009-01-31  3:06 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20090131022548.656772939@mini.kroah.org>
2009-01-31  2:41 ` [patch 00/43] 2.6.28-stable review Greg KH
2009-01-31  2:42   ` [patch 01/43] ath5k: fix mesh point operation Greg KH
2009-01-31  2:42   ` [patch 02/43] mac80211: decrement ref count to netdev after launching mesh discovery Greg KH
2009-01-31  2:42   ` [patch 03/43] inotify: clean up inotify_read and fix locking problems Greg KH
2009-01-31  2:42   ` [patch 04/43] fuse: destroy bdi on umount Greg KH
2009-01-31  2:42   ` [patch 05/43] fuse: fix missing fput on error Greg KH
2009-01-31  2:42   ` [patch 06/43] fuse: fix NULL deref in fuse_file_alloc() Greg KH
2009-01-31  2:42   ` [patch 07/43] x86, mm: fix pte_free() Greg KH
2009-01-31  2:42   ` [patch 08/43] klist.c: bit 0 in pointer cant be used as flag Greg KH
2009-01-31  2:42   ` [patch 09/43] sysfs: fix problems with binary files Greg KH
2009-01-31  2:42   ` [patch 10/43] x86: fix page attribute corruption with cpa() Greg KH
2009-01-31  2:42   ` [patch 11/43] USB: fix toggle mismatch in disable_endpoint paths Greg KH
2009-01-31  2:42   ` [patch 12/43] sound: virtuoso: enable UART on Xonar HDAV1.3 Greg KH
2009-01-31  2:42   ` [patch 13/43] USB: usbmon: Implement compat_ioctl Greg KH
2009-01-31  2:42   ` [patch 14/43] USB: fix char-device disconnect handling Greg KH
2009-01-31  2:42   ` [patch 15/43] USB: storage: add unusual devs entry Greg KH
2009-01-31  2:42   ` [patch 16/43] alpha: nautilus - fix compile failure with gcc-4.3 Greg KH
2009-01-31  2:42   ` [patch 17/43] alpha: fix vmalloc breakage Greg KH
2009-01-31  2:42   ` [patch 18/43] resources: skip sanity check of busy resources Greg KH
2009-01-31  2:42   ` [patch 19/43] rtl8187: Add termination packet to prevent stall Greg KH
2009-01-31  2:42   ` Greg KH [this message]
2009-01-31  2:42   ` [patch 21/43] libata: pata_via: support VX855, future chips whose IDE controller use 0x0571 Greg KH
2009-01-31  2:42   ` [patch 22/43] serial_8250: support for Sealevel Systems Model 7803 COMM+8 Greg KH
2009-01-31  2:43   ` [patch 23/43] drm: stash AGP include under the do-we-have-AGP ifdef Greg KH
2009-01-31  2:43   ` [patch 24/43] Fix OOPS in mmap_region() when merging adjacent VM_LOCKED file segments Greg KH
2009-01-31  2:43   ` [patch 25/43] bnx2x: Block nvram access when the device is inactive Greg KH
2009-01-31  2:43   ` [patch 26/43] ext3: Add sanity check to make_indexed_dir Greg KH
2009-01-31  2:43   ` [patch 27/43] rtl8187: Fix error in setting OFDM power settings for RTL8187L Greg KH
2009-01-31  2:44   ` [patch 28/43] epoll: drop max_user_instances and rely only on max_user_watches Greg KH
2009-01-31  2:44   ` [patch 29/43] gpiolib: fix request related issue Greg KH
2009-01-31  2:44   ` [patch 30/43] sgi-xpc: Remove NULL pointer dereference Greg KH
2009-01-31  2:44   ` [patch 31/43] sgi-xpc: ensure flags are updated before bte_copy Greg KH
2009-01-31  2:44   ` [patch 32/43] include/linux: Add bsg.h to the Kernel exported headers Greg KH
2009-01-31  2:44   ` [patch 33/43] ALSA: hda - Fix PCM reference NID for STAC/IDT analog outputs Greg KH
2009-01-31  2:44   ` [patch 34/43] ALSA: hda - add another MacBook Pro 4, 1 subsystem ID Greg KH
2009-01-31  2:44   ` [patch 35/43] ALSA: hda - Add quirk for HP DV6700 laptop Greg KH
2009-01-31  2:44   ` [patch 36/43] crypto: authenc - Fix zero-length IV crash Greg KH
2009-01-31  2:44   ` [patch 37/43] crypto: ccm - Fix handling of null assoc data Greg KH
2009-01-31  2:44   ` [patch 38/43] x86, pat: fix reserve_memtype() for legacy 1MB range Greg KH
2009-01-31  2:44   ` [patch 39/43] x86, pat: fix PTE corruption issue while mapping RAM using /dev/mem Greg KH
2009-01-31  2:44   ` [patch 40/43] PCI hotplug: fix lock imbalance in pciehp Greg KH
2009-01-31  2:44   ` [patch 41/43] dmaengine: fix dependency chaining Greg KH
2009-01-31  2:45   ` [patch 42/43] NET: net_namespace, fix lock imbalance Greg KH
2009-01-31  2:45   ` [patch 43/43] relay: fix lock imbalance in relay_late_setup_files Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090131024255.GU12368@kroah.com \
    --to=gregkh@suse.de \
    --cc=akpm@linux-foundation.org \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=bphilips@suse.de \
    --cc=bzolnier@gmail.com \
    --cc=cavokz@gmail.com \
    --cc=cebbert@redhat.com \
    --cc=chuckw@quantumlinux.com \
    --cc=davej@redhat.com \
    --cc=eteo@redhat.com \
    --cc=jake@lwn.net \
    --cc=jmforbes@linuxtx.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mkrufky@linuxtv.org \
    --cc=rbranco@la.checkpoint.com \
    --cc=rdunlap@xenotime.net \
    --cc=reviews@ml.cw.f00f.org \
    --cc=stable@kernel.org \
    --cc=torvalds@linux-foundation.org \
    --cc=tytso@mit.edu \
    --cc=w@1wt.eu \
    --cc=zwane@arm.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.