From: Joerg Roedel <joro@8bytes.org>
To: Robert Hancock <hancockr@shaw.ca>
Cc: Roger Larsson <roger.larsson@e-gatan.se>,
linux-kernel@vger.kernel.org, Ingo Molnar <mingo@elte.hu>,
Robert Love <rml@tech9.net>, Pavel Machek <pavel@ucw.cz>
Subject: Re: PROBLEM: in_atomic() misuse all over the place
Date: Sat, 31 Jan 2009 12:45:20 +0100 [thread overview]
Message-ID: <20090131114520.GA26910@8bytes.org> (raw)
In-Reply-To: <497FA2D0.1090605@shaw.ca>
On Tue, Jan 27, 2009 at 06:12:00PM -0600, Robert Hancock wrote:
> I would think that the code that's using it for this purpose should be
> changed to do things differently, such as by changing the functions
> using it to make their caller pass in the proper GFP mask. I don't think
> it was ever intended to be used to select allocation behavior like this,
> only for debug warning checks and such.. Getting rid of in_atomic() and
> creating a in_atomic_warn() that just raises a warning if called
> atomically, might be the best long-term solution.
I also made the mistake of using in_atomic() wrong in one of my last
patch sets. In my case this was pointed out by the reviewers. Is there
some documentation in the kernel tree how and when in_atomic() is used
right? If not I think its worth writing a little file that explains the
important details about the correct use of in_atomic() :-)
Joerg
next prev parent reply other threads:[~2009-01-31 11:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-27 23:10 PROBLEM: in_atomic() misuse all over the place Roger Larsson
2009-01-28 0:12 ` Robert Hancock
2009-01-31 11:45 ` Joerg Roedel [this message]
2009-01-28 12:18 ` Andi Kleen
2009-01-31 0:03 ` Andrew Morton
2009-01-31 5:55 ` Andi Kleen
2009-01-31 5:49 ` Andrew Morton
2009-01-31 8:48 ` David Miller
2009-01-31 8:58 ` Andrew Morton
2009-02-04 16:17 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090131114520.GA26910@8bytes.org \
--to=joro@8bytes.org \
--cc=hancockr@shaw.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=pavel@ucw.cz \
--cc=rml@tech9.net \
--cc=roger.larsson@e-gatan.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.