All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2] common/console: coding style cleanup
Date: Sun, 1 Feb 2009 14:07:27 +0100	[thread overview]
Message-ID: <20090201130727.GF9067@game.jcrosoft.org> (raw)
In-Reply-To: <20090201113212.6A79383644C3@gemini.denx.de>

On 12:32 Sun 01 Feb     , Wolfgang Denk wrote:
> Dear Jean-Christophe PLAGNIOL-VILLARD,
> 
> In message <1233486771-10411-1-git-send-email-plagnioj@jcrosoft.com> you wrote:
> > Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
> > ---
> >  common/console.c |   97 ++++++++++++++++++++++++++++--------------------------
> >  1 files changed, 50 insertions(+), 47 deletions(-)
> > 
> > diff --git a/common/console.c b/common/console.c
> > index 89aeab6..851b0f8 100644
> > --- a/common/console.c
> > +++ b/common/console.c
> > @@ -106,39 +106,39 @@ int cd_count[MAX_FILES];
> >   * only from fgetc() which assures it.
> >   * No attempt is made to demultiplex multiple input sources.
> >   */
> > -static int iomux_getc(void)
> > +static int iomux_getc (void)
> ...
> > -static int iomux_tstc(int file)
> > +static int iomux_tstc (int file)
> 
> NAK.
> 
> This Linux kernel coding style does NOT insert spaces between
> function names; your patch makes the style worse, not better.
It's the coding style use in this file

so what do you prefer?

Best Regards,
J.

  reply	other threads:[~2009-02-01 13:07 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-01 11:12 [U-Boot] [PATCH 1/2] common/console: coding style cleanup Jean-Christophe PLAGNIOL-VILLARD
2009-02-01 11:12 ` [U-Boot] [PATCH 2/2] common/console: avoid ifdef CONFIG_CONSOLE_MUX when it's possible Jean-Christophe PLAGNIOL-VILLARD
2009-02-01 11:35   ` Wolfgang Denk
2009-02-01 11:32 ` [U-Boot] [PATCH 1/2] common/console: coding style cleanup Wolfgang Denk
2009-02-01 13:07   ` Jean-Christophe PLAGNIOL-VILLARD [this message]
2009-02-01 15:12     ` Wolfgang Denk
2009-02-01 16:07 ` [U-Boot] [PATCH 1/2 v2] " Jean-Christophe PLAGNIOL-VILLARD
2009-02-01 16:07   ` [U-Boot] [PATCH 2/2 V2] common/console: avoid ifdef CONFIG_CONSOLE_MUX when it's possible Jean-Christophe PLAGNIOL-VILLARD
2009-02-17 23:55     ` Wolfgang Denk
2009-02-17 23:54   ` [U-Boot] [PATCH 1/2 v2] common/console: coding style cleanup Wolfgang Denk
  -- strict thread matches above, loose matches on Subject: below --
2009-02-01 11:37 [U-Boot] [PATCH 1/2] " Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090201130727.GF9067@game.jcrosoft.org \
    --to=plagnioj@jcrosoft.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.