From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LU3Tl-0001CB-FF
	for qemu-devel@nongnu.org; Mon, 02 Feb 2009 13:25:05 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LU3Tj-0001Bt-6q
	for qemu-devel@nongnu.org; Mon, 02 Feb 2009 13:25:04 -0500
Received: from [199.232.76.173] (port=46375 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LU3Ti-0001Bo-VJ
	for qemu-devel@nongnu.org; Mon, 02 Feb 2009 13:25:03 -0500
Received: from mx20.gnu.org ([199.232.41.8]:7673)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <froydnj@codesourcery.com>)
	id 1LU3Ti-0004tG-Me
	for qemu-devel@nongnu.org; Mon, 02 Feb 2009 13:25:02 -0500
Received: from mail.codesourcery.com ([65.74.133.4])
	by mx20.gnu.org with esmtp (Exim 4.60)
	(envelope-from <froydnj@codesourcery.com>) id 1LU3Ti-0005q3-13
	for qemu-devel@nongnu.org; Mon, 02 Feb 2009 13:25:02 -0500
Date: Mon, 2 Feb 2009 10:25:01 -0800
From: Nathan Froyd <froydnj@codesourcery.com>
Subject: Re: [Qemu-devel] [PATCH] Add multi-boot kernel loading support
Message-ID: <20090202182501.GC15286@codesourcery.com>
References: <49873680.2040603@exactcode.de>
	<20090202181541.GB15286@codesourcery.com>
	<498738AE.6080808@suse.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <498738AE.6080808@suse.de>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexander Graf <agraf@suse.de>
Cc: =?iso-8859-1?Q?Ren=E9?= Rebe <rene@exactcode.de>, qemu-devel@nongnu.org

On Mon, Feb 02, 2009 at 07:17:18PM +0100, Alexander Graf wrote:
> Nathan Froyd wrote:
> > On Mon, Feb 02, 2009 at 07:08:00PM +0100, Rene Rebe wrote:
> >> +    /* 660f011528000000            lgdt [0x28] */
> >> +    *p++ = 0x66;                /* 32-bit operand size */
> >> +    *p++ = 0x67;                /* 32-bit addr size */
> >> +    *p++ = 0x0f;                /* LGDT [0x128] */
> >> +    *p++ = 0x01;
> >> +    *p++ = 0x15;
> >> +    pgdt=p; /* we calculate the gdt position later */
> >> +    p+=4;
> >>     
> >
> > The comments do not appear to agree with the code here.  (The operands
> > for lgdt are different, at the very least.)
>
> Right, because the operands are actually calculated dynamically. Any
> suggestions on how to improve that? Maybe LGDT [GDT]?

Yes, I think that would be an improvement.  Editing the bytestring to
reflect that would be good, as well.

-Nathan