From: Greg KH <greg@kroah.com>
To: Daniel Walker <dwalker@fifo99.com>
Cc: Andy Whitcroft <apw@canonical.com>, linux-kernel@vger.kernel.org
Subject: Re: checkpatch.pl is getting too slow
Date: Mon, 2 Feb 2009 21:16:32 -0800 [thread overview]
Message-ID: <20090203051632.GA13289@kroah.com> (raw)
In-Reply-To: <1233510446.5903.87.camel@desktop>
On Sun, Feb 01, 2009 at 09:47:26AM -0800, Daniel Walker wrote:
>
>
> I found a little more on this.. It seems the problem with #define lines
> only causes a few extra seconds delay .. I found another issue C99 style
> comments.
>
> On line 642 your file has this line,
>
> // For the UART control registers, the application number need to be Or'ed
>
> The quote in Or'ed causes checkpatch to treat the rest of the file as a
> big string that never closes. Or that's my impression. The delay is
> caused in the same way as the define delay. In order to check one line
> in the file the rest of the file is scanned.
>
> The fix below increased the number of errors found too.
>
> total: 347 errors, 278 warnings, 3932 lines checked
Nice, this looks good to me, thanks for figuring this out.
Andy, any thoughts?
greg k-h
next prev parent reply other threads:[~2009-02-03 5:18 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-31 18:55 checkpatch.pl is getting too slow Greg KH
2009-01-31 21:02 ` Andy Whitcroft
2009-01-31 21:35 ` Daniel Walker
2009-01-31 22:10 ` Daniel Walker
2009-02-01 0:57 ` Daniel Walker
2009-02-01 4:46 ` Greg KH
2009-02-01 14:33 ` Daniel Walker
2009-02-01 17:47 ` Daniel Walker
2009-02-03 5:16 ` Greg KH [this message]
2009-02-09 8:41 ` Andy Whitcroft
2009-02-09 8:58 ` Andy Whitcroft
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090203051632.GA13289@kroah.com \
--to=greg@kroah.com \
--cc=apw@canonical.com \
--cc=dwalker@fifo99.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.