Re: 2.6.29-rc3-git5 build failure : drivers/staging/panel

[Willy Tarreau <w@1wt.eu>]

Hi,

On Tue, Feb 03, 2009 at 08:45:38PM +0530, Sachin P. Sant wrote:
> 2.6.29-rc3-git5 randconfig build on powerpc fails with following error
> 
> CALL    arch/powerpc/kernel/systbl_chk.sh
> CALL    arch/powerpc/kernel/prom_init_check.sh
> CC [M]  drivers/staging/panel/panel.o
> drivers/staging/panel/panel.c:625: error: conflicting types for set_bits
> /home/sachin/linux-2.6.29-rc3-git5/arch/powerpc/include/asm/bitops.h:216: 
> error: previous definition of set_bits was here
> make[3]: *** [drivers/staging/panel/panel.o] Error 1
> make[2]: *** [drivers/staging/panel] Error 2
> make[1]: *** [drivers/staging] Error 2
> make: *** [drivers] Error 2
> 
> Will provide .config if required.

I don't think any config will be needed. The problem is that we have
conflicting names between global and local functions. Could you please
try to rename "set_bits" as weel as the few references to this function
in panel.c ? I'd suggest you name it "panel_set_bits".

I can work on a patch if needed, but since the fix is really easy I'd
prefer to get a confirmation that it's enough.

Thanks for the report,
Willy