From: Andrew Morton <akpm@linux-foundation.org>
To: Mike Christie <michaelc@cs.wisc.edu>
Cc: Kyle McMartin <kyle@infradead.org>, linux-scsi@vger.kernel.org
Subject: Re: iscsi_add_session() warning
Date: Tue, 3 Feb 2009 23:50:04 -0800 [thread overview]
Message-ID: <20090203235004.0377e4de.akpm@linux-foundation.org> (raw)
In-Reply-To: <4989465B.9060109@cs.wisc.edu>
On Wed, 04 Feb 2009 01:40:11 -0600 Mike Christie <michaelc@cs.wisc.edu> wrote:
> When there are no ids for some object left, what is the stadard Exxxx
> value to return? Would ENOSPC make sense? Here ENOSPC would mean no
> space in id space left instead of space on a device?
Drivers often do that sort of thing. I don't like it personally -
ENOSPC means "No space left on device". IOW, "your disk is full".
Co-opting that code just because something kinda-sorta-similar happened
seems abusive to me. Plus the first thing poor old user is going to do
is run `df' and ask wtf?
So what's left? EINVAL is a sort of generic something-went-wrong error
code (in Linux, at least). But perhaps EBUSY ("Device or resource
busy") is suitable here.
Dunno, hard.
next prev parent reply other threads:[~2009-02-04 7:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-04 0:09 iscsi_add_session() warning Andrew Morton
2009-02-04 0:12 ` Kyle McMartin
2009-02-04 0:22 ` Andrew Morton
2009-02-04 7:40 ` Mike Christie
2009-02-04 7:50 ` Andrew Morton [this message]
2009-02-04 17:56 ` Grant Grundler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090203235004.0377e4de.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=kyle@infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=michaelc@cs.wisc.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.