All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Frans Pop <elendil@planet.nl>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [BUG] Suspend tries to suspend devices already in D3
Date: Wed, 4 Feb 2009 02:25:21 +0100	[thread overview]
Message-ID: <200902040225.22113.rjw@sisk.pl> (raw)
In-Reply-To: <200902031842.44186.elendil@planet.nl>

On Tuesday 03 February 2009, Frans Pop wrote:
> On Tuesday 03 February 2009, Frans Pop wrote:
> > Looking at iwl-agn.c the cause could be that iwl_pci_suspend() depends
> > on iwl_mac_stop() to call pci_save_state(). I added some debug
> > statements in iwl_pci_suspend() that showed priv->is_open is false, so
> > iwl_mac_stop does indeed *not* get called when the interface is down.
> 
> However, iwl_mac_stop() had been called when I ran ifdown just before
> suspending the system:

The problem that the warning can be triggered by a device being in a low
power state already before suspend should be fixed by the PCI PM fixes I've
just posted.

Thanks,
Rafael

  reply	other threads:[~2009-02-04  1:25 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-03  8:49 [BUG] Suspend tries to suspend devices already in D3 Frans Pop
2009-02-03  9:34 ` Rafael J. Wysocki
2009-02-03  9:59   ` Frans Pop
2009-02-03 17:33   ` Frans Pop
2009-02-03 17:42     ` Frans Pop
2009-02-04  1:25       ` Rafael J. Wysocki [this message]
2009-02-04 11:58         ` Frans Pop
2009-02-04 12:17           ` Rafael J. Wysocki
2009-02-14  0:48             ` Frans Pop

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200902040225.22113.rjw@sisk.pl \
    --to=rjw@sisk.pl \
    --cc=elendil@planet.nl \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.