From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760578AbZBDSov (ORCPT ); Wed, 4 Feb 2009 13:44:51 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1758160AbZBDShZ (ORCPT ); Wed, 4 Feb 2009 13:37:25 -0500 Received: from kroah.org ([198.145.64.141]:51099 "EHLO coco.kroah.org" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754529AbZBDShS (ORCPT ); Wed, 4 Feb 2009 13:37:18 -0500 Date: Wed, 4 Feb 2009 10:34:57 -0800 From: Greg KH To: linux-kernel@vger.kernel.org, stable@kernel.org, Greg KH Cc: Justin Forbes , Zwane Mwaikambo , "Theodore Ts'o" , Randy Dunlap , Dave Jones , Chuck Wolber , Chris Wedgwood , Michael Krufky , Chuck Ebbert , Domenico Andreoli , Willy Tarreau , Rodrigo Rubira Branco , Jake Edge , Eugene Teo , torvalds@linux-foundation.org, akpm@linux-foundation.org, alan@lxorguk.ukuu.org.uk, Johannes Berg , linville@tuxdriver.com, Larry.Finger@lwfinger.net, Christian Lamparter Subject: [patch 21/33] p54: fix lm87 checksum endianness Message-ID: <20090204183457.GV13936@kroah.com> References: <20090204182823.831027530@mini.kroah.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline; filename="p54-fix-lm87-checksum-endianness.patch" In-Reply-To: <20090204183403.GA13936@kroah.com> User-Agent: Mutt/1.5.16 (2007-06-09) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 2.6.28-stable review patch. If anyone has any objections, please let us know. ------------------ From: Johannes Berg commit c91276592695e13d1b52eab572551017cbf96ee7 upstream This fixes the checksum calculation for lm87 firmwares on big endian platforms, the device treats the data as an array of 32-bit little endian values so the driver needs to do that as well. Signed-off-by: Johannes Berg Acked-by: Christian Lamparter Signed-off-by: John W. Linville --- drivers/net/wireless/p54/p54usb.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) --- a/drivers/net/wireless/p54/p54usb.c +++ b/drivers/net/wireless/p54/p54usb.c @@ -222,13 +222,13 @@ static void p54u_tx_3887(struct ieee8021 usb_submit_urb(data_urb, GFP_ATOMIC); } -static __le32 p54u_lm87_chksum(const u32 *data, size_t length) +static __le32 p54u_lm87_chksum(const __le32 *data, size_t length) { u32 chk = 0; length >>= 2; while (length--) { - chk ^= *data++; + chk ^= le32_to_cpu(*data++); chk = (chk >> 5) ^ (chk << 3); } @@ -247,7 +247,7 @@ static void p54u_tx_lm87(struct ieee8021 if (!data_urb) return; - hdr->chksum = p54u_lm87_chksum((u32 *)data, len); + hdr->chksum = p54u_lm87_chksum((__le32 *) data, len); hdr->device_addr = data->req_id; usb_fill_bulk_urb(data_urb, priv->udev,