From: Ingo Molnar <mingo@elte.hu>
To: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: "Steven Rostedt" <rostedt@goodmis.org>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
"Frédéric Weisbecker" <fweisbec@gmail.com>,
"Jens Axboe" <jens.axboe@oracle.com>
Subject: Re: [PATCH tip 1/1] trace: judicious error checking of trace_seq results
Date: Wed, 4 Feb 2009 20:46:35 +0100 [thread overview]
Message-ID: <20090204194635.GC22608@elte.hu> (raw)
In-Reply-To: <20090203222041.GE3440@ghostprotocols.net>
* Arnaldo Carvalho de Melo <acme@redhat.com> wrote:
> Impact: bugfix/cleanup
>
> Some callsites were returning either TRACE_ITER_PARTIAL_LINE if the
> trace_seq routines (trace_seq_printf, etc) returned 0 meaning its buffer
> was full, or zero otherwise.
>
> But...
>
> /* Return values for print_line callback */
> enum print_line_t {
> TRACE_TYPE_PARTIAL_LINE = 0, /* Retry after flushing the seq */
> TRACE_TYPE_HANDLED = 1,
> TRACE_TYPE_UNHANDLED = 2 /* Relay to other output functions */
> };
>
> In other cases the return value was not being relayed at all.
>
> Most of the time it didn't hurt because the page wasn't get filled, but
> for correctness sake, handle the return values everywhere.
applied to tip:tracing/ftrace, thanks Arnaldo!
Ingo
prev parent reply other threads:[~2009-02-04 19:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-03 22:20 [PATCH tip 1/1] trace: judicious error checking of trace_seq results Arnaldo Carvalho de Melo
2009-02-03 22:49 ` Frederic Weisbecker
2009-02-04 0:05 ` [PATCH tip 1/1] trace: Make the trace_event callbacks return enum print_line_t Arnaldo Carvalho de Melo
2009-02-04 1:06 ` Frederic Weisbecker
2009-02-04 19:47 ` Ingo Molnar
2009-02-04 19:46 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090204194635.GC22608@elte.hu \
--to=mingo@elte.hu \
--cc=acme@redhat.com \
--cc=fweisbec@gmail.com \
--cc=jens.axboe@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.