Re: [PATCHv2] uio: add the uio_aec driver

[Greg KH <greg@kroah.com>]

On Fri, Jan 30, 2009 at 12:26:17AM +0100, Hans J. Koch wrote:
> On Tue, Jan 27, 2009 at 01:00:04PM -0800, Brandon Philips wrote:
> > UIO driver for the Adrienne Electronics Corporation PCI time code
> > device.
> 
> Sorry for not reviewing this earlier, I was quite busy this week and didn't
> work at my home office.
> I know I'm a bit late, since Greg already added it to his tree, but I reviewed
> it anyway. Nice piece of work. I've got no objections either.
> 
> > 
> > This device differs from other UIO devices since it uses I/O ports instead of
> > memory mapped I/O. In order to make it possible for UIO to work with this
> > device a utility, uioport, can be used to read and write the ports.
> > 
> > uioport is designed to be a setuid program and checks the permissions of
> > the /dev/uio* node and if the user has write permissions it will use
> > iopl and out*/in* to access the device.
> > 
> > [1] git clone git://ifup.org/philips/uioport.git
> > 
> > Signed-off-by: Brandon Philips <brandon@ifup.org>
> 
> Signed-off-by: Hans J. Koch <hjk@linutronix.de>

Thanks for the review, I've added your signed-off-by to the patch in my
queue.

greg k-h