All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Gerhard Pircher" <gerhard_pircher@gmx.net>
To: linuxppc-dev list <linuxppc-dev@ozlabs.org>
Subject: [RFC] Error handling in *_add/find_bridges()
Date: Thu, 05 Feb 2009 14:36:51 +0100	[thread overview]
Message-ID: <20090205133651.81040@gmx.net> (raw)
In-Reply-To: <1233780436.4612.0.camel@pasglop>

Hi!

I have a minor question about the error handling in the various *_add/find_bridges functions, which are used to detect and initialize
PHBs. AFAIK all of them return an error code that is never checked in
the platform setup code (e.g. when there is no memory for the
pci_controller struct).
Shouldn't the kernel panic (BUG();), when it can't initialize the PHB
for whatever reason and the platform depends on a working PCI bus?

Thanks!

regards,

Gerhard
-- 
Jetzt 1 Monat kostenlos! GMX FreeDSL - Telefonanschluss + DSL 
für nur 17,95 Euro/mtl.!* http://dsl.gmx.de/?ac=OM.AD.PD003K11308T4569a

  reply	other threads:[~2009-02-05 13:36 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-02 21:21 AmigaOne platform patches v2 Gerhard Pircher
2009-02-02 21:39 ` [PATCH v2 1/4] Add platform support for AmigaOne Gerhard Pircher
2009-02-04  3:50   ` Benjamin Herrenschmidt
2009-02-04 12:09     ` Gerhard Pircher
2009-02-04 20:47       ` Benjamin Herrenschmidt
2009-02-05 13:36         ` Gerhard Pircher [this message]
2009-02-04 20:59     ` Gabriel Paubert
2009-02-04 21:35       ` Gerhard Pircher
2009-02-04 21:39         ` John W. Linville

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090205133651.81040@gmx.net \
    --to=gerhard_pircher@gmx.net \
    --cc=linuxppc-dev@ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.