From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Morton Subject: Re: [PATCH 3/5] Blackfin SPI Driver: fix NULL pointer crash Date: Thu, 5 Feb 2009 14:12:50 -0800 Message-ID: <20090205141250.cf66e663.akpm@linux-foundation.org> References: <1233828453-13311-1-git-send-email-cooloney@kernel.org> <1233828453-13311-4-git-send-email-cooloney@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: dbrownell@users.sourceforge.net, spi-devel-general@lists.sourceforge.net, linux-kernel@vger.kernel.org, vapier.adi@gmail.com, cooloney@kernel.org To: Bryan Wu Return-path: In-Reply-To: <1233828453-13311-4-git-send-email-cooloney@kernel.org> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-spi.vger.kernel.org On Thu, 5 Feb 2009 18:07:31 +0800 Bryan Wu wrote: > From: Mike Frysinger > > fix NULL pointer crash when cleaning up from invalid platform resources > > Signed-off-by: Mike Frysinger > Signed-off-by: Bryan Wu > --- > drivers/spi/spi_bfin5xx.c | 3 +++ > 1 files changed, 3 insertions(+), 0 deletions(-) > > diff --git a/drivers/spi/spi_bfin5xx.c b/drivers/spi/spi_bfin5xx.c > index ce24d5e..b6098b5 100644 > --- a/drivers/spi/spi_bfin5xx.c > +++ b/drivers/spi/spi_bfin5xx.c > @@ -1240,6 +1240,9 @@ static void bfin_spi_cleanup(struct spi_device *spi) > { > struct chip_data *chip = spi_get_ctldata(spi); > > + if (!chip) > + return; > + > if ((chip->chip_select_num > 0) > && (chip->chip_select_num <= spi->master->num_chipselect)) > peripheral_free(ssel[spi->master->bus_num] This one looks like 2.6.29 material to me. If you believe that it should be backported to earlier kernels then please let me know. indicating whcih kernel versions would help things a bit, too.