All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Floris Kraak <randakar@gmail.com>,
	Arjan van de Ven <arjan@infradead.org>
Cc: Roland Dreier <rdreier@cisco.com>,
	Robert Hancock <hancockrwd@gmail.com>,
	Sam Ravnborg <sam@ravnborg.org>,
	Alan Cox <alan@lxorguk.ukuu.org.uk>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Trivial Patch Monkey <trivial@kernel.org>,
	Andreas Schwab <schwab@suse.de>
Subject: Re: [PATCH]: Cleanup: Remove gcc format string warnings when compiling with -Wformat-security (was: Re: [PATCH] Kbuild: Disable the -Wformat-security gcc flag)
Date: Thu, 5 Feb 2009 15:52:26 +0100	[thread overview]
Message-ID: <20090205145226.GA23903@elte.hu> (raw)
In-Reply-To: <56e1b5710902050641l5ece10e5hedd11fb3f4292886@mail.gmail.com>


* Floris Kraak <randakar@gmail.com> wrote:

> --- a/arch/x86/kernel/dumpstack.c
> +++ b/arch/x86/kernel/dumpstack.c
> @@ -112,7 +112,7 @@ print_context_stack(struct thread_info *tinfo,
>  static void
>  print_trace_warning_symbol(void *data, char *msg, unsigned long symbol)
>  {
> -	printk(data);
> +	printk("%s", data);
>  	print_symbol(msg, symbol);
>  	printk("\n");

Arjan, the code above seems to be dead and never called. These methods:

static const struct stacktrace_ops print_trace_ops = {
        .warning = print_trace_warning,
        .warning_symbol = print_trace_warning_symbol,

are not used anywhere that i can see. Could you have a look at this please?

	Ingo

  reply	other threads:[~2009-02-05 14:53 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-05 14:41 [PATCH]: Cleanup: Remove gcc format string warnings when compiling with -Wformat-security (was: Re: [PATCH] Kbuild: Disable the -Wformat-security gcc flag) Floris Kraak
2009-02-05 14:52 ` Ingo Molnar [this message]
2009-02-05 15:22 ` Mike Isely
2009-02-05 15:38   ` Floris Kraak
2009-02-05 16:34 ` Floris Kraak
2009-02-05 22:13 ` [PATCH]: Cleanup: Remove gcc format string warnings when compiling with -Wformat-security Roland Dreier
2009-02-05 22:41   ` Floris Kraak
2009-02-05 23:42   ` Robert Hancock
2009-02-06 10:36     ` Floris Kraak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090205145226.GA23903@elte.hu \
    --to=mingo@elte.hu \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=arjan@infradead.org \
    --cc=hancockrwd@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=randakar@gmail.com \
    --cc=rdreier@cisco.com \
    --cc=sam@ravnborg.org \
    --cc=schwab@suse.de \
    --cc=trivial@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.