From: Stanislaw Gruszka <stf_xl@wp.pl>
To: Andrew Victor <avictor.za@gmail.com>
Cc: linux-ide@vger.kernel.org, Andrew Victor <linux@maxim.org.za>,
linux-arm-kernel@lists.arm.linux.org.uk
Subject: Re: [PATCH 3/3] AT91: initialize IDE driver on AT91SAM9263 cpu
Date: Thu, 5 Feb 2009 16:06:04 +0100 [thread overview]
Message-ID: <200902051606.04181.stf_xl@wp.pl> (raw)
In-Reply-To: <cd73a99e0902031227x678ebfa3h14207aeaf00a406c@mail.gmail.com>
Tuesday 03 February 2009 21:27:04 Andrew Victor napisał(a):
> hi Stanislaw,
>
> > +void __init at91_add_device_ide(struct at91_ide_data *data)
> > +{
>
> This platform initialization code is virtually identical to the
> at91_cf version submitted by Uros Bizjak, albeit for the SAM9260.
> Similarly the "at91_cf_data" and "at91_ide_data" structs.
Shouldn't be sam9_smc_config stuff be in board file not in cpu file,
in place where you know what is the clock frequency. Could you
assume cpu is clocked with some particular freqency?
Cheers
Stanislaw Gruszka
next prev parent reply other threads:[~2009-02-05 15:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-03 10:47 [PATCH 3/3] AT91: initialize IDE driver on AT91SAM9263 cpu Stanislaw Gruszka
2009-02-03 20:27 ` Andrew Victor
2009-02-04 9:36 ` Stanislaw Gruszka
2009-02-05 12:03 ` Sergei Shtylyov
2009-02-05 19:43 ` Andrew Victor
2009-02-05 20:01 ` Sergei Shtylyov
2009-02-05 23:52 ` Sergei Shtylyov
2009-02-05 15:06 ` Stanislaw Gruszka [this message]
2009-02-04 12:18 ` Sergei Shtylyov
2009-02-04 14:15 ` Stanislaw Gruszka
2009-02-04 15:46 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200902051606.04181.stf_xl@wp.pl \
--to=stf_xl@wp.pl \
--cc=avictor.za@gmail.com \
--cc=linux-arm-kernel@lists.arm.linux.org.uk \
--cc=linux-ide@vger.kernel.org \
--cc=linux@maxim.org.za \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.