From: David Brownell <david-b@pacbell.net>
To: tom.leiming@gmail.com
Cc: greg@kroah.com, kay.sievers@vrfy.org, LW@karo-electronics.de,
hmh@hmh.eng.br, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] platform driver:fix incorrect use of 'platform_bus_type' with 'struct device_driver'
Date: Fri, 6 Feb 2009 09:59:22 -0800 [thread overview]
Message-ID: <200902060959.22413.david-b@pacbell.net> (raw)
In-Reply-To: <1233934812-20628-1-git-send-email-tom.leiming@gmail.com>
On Friday 06 February 2009, tom.leiming@gmail.com wrote:
> From: Ming Lei <tom.leiming@gmail.com>
>
> This patch fixes the bug reported in
> http://bugzilla.kernel.org/show_bug.cgi?id=11681.
>
> "Lots of device drivers register a 'struct device_driver' with
> the '.bus' member set to '&platform_bus_type'. This is wrong,
> since the platform_bus functions expect the 'struct device_driver'
> to be wrapped up in a 'struct platform_driver' which provides
> some additional callbacks (like suspend_late, resume_early).
> The effect may be that platform_suspend_late() uses bogus data
> outside the device_driver struct as a pointer pointer to the
> device driver's suspend_late() function or other hard to
> reproduce failures."(Lothar Wassmann)
>
> Signed-off-by: Ming Lei <tom.leiming@gmail.com>
I just glanced at this ... but those parts looked like
good fixes to this family of bugs. Thanks.
- Dave
next prev parent reply other threads:[~2009-02-06 17:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-06 15:40 [PATCH] platform driver:fix incorrect use of 'platform_bus_type' with 'struct device_driver' tom.leiming
2009-02-06 17:59 ` David Brownell [this message]
2009-02-06 19:12 ` Henrique de Moraes Holschuh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200902060959.22413.david-b@pacbell.net \
--to=david-b@pacbell.net \
--cc=LW@karo-electronics.de \
--cc=greg@kroah.com \
--cc=hmh@hmh.eng.br \
--cc=kay.sievers@vrfy.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tom.leiming@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.