From: Mark Brown <broonie@sirena.org.uk>
To: Bryan Wu <cooloney@kernel.org>
Cc: alsa-devel@alsa-project.org, Cliff Cai <cliff.cai@analog.com>
Subject: Re: [PATCH 3/3] ASoC: Blackfin: fix bug - kernel will crash when record and play in bf527-ezkit
Date: Fri, 6 Feb 2009 11:56:45 +0000 [thread overview]
Message-ID: <20090206115626.GD8723@sirena.org.uk> (raw)
In-Reply-To: <1233915156-17985-4-git-send-email-cooloney@kernel.org>
On Fri, Feb 06, 2009 at 06:12:36PM +0800, Bryan Wu wrote:
> From: Cliff Cai <cliff.cai@analog.com>
>
> set constraint only if the value is not 0, change the configuring way for sport
> Signed-off-by: Cliff Cai <cliff.cai@analog.com>
> Signed-off-by: Bryan Wu <cooloney@kernel.org>
If this is fixing a kernel crash we should push it for 2.6.29 (the code
hasn't changed so I'm assuming it occurs there). What is the crash that
is being fixed?
> ---
> sound/soc/blackfin/bf5xx-i2s.c | 25 ++++---------------------
> sound/soc/codecs/ssm2602.c | 29 ++++++++++++++---------------
> 2 files changed, 18 insertions(+), 36 deletions(-)
Presumably only one of these drivers needs to be changed for the crash
fix? I'd have expected to see two separate patches for the two separate
drivers - the changes don't depend on each other and do very different
things.
next prev parent reply other threads:[~2009-02-06 11:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-06 10:12 [PATCH 0/3] ASoC Blackfin updates Bryan Wu
2009-02-06 10:12 ` [PATCH 1/3] ASoC: Blackfin: cleanup sport handling in ASoC Blackfin AC97 code Bryan Wu
2009-02-06 11:57 ` Mark Brown
2009-02-06 10:12 ` [PATCH 2/3] ASoC: Blackfin: drop unnecessary dma casts Bryan Wu
2009-02-06 12:06 ` Mark Brown
2009-02-06 10:12 ` [PATCH 3/3] ASoC: Blackfin: fix bug - kernel will crash when record and play in bf527-ezkit Bryan Wu
2009-02-06 11:56 ` Mark Brown [this message]
2009-02-13 20:18 ` Mark Brown
2009-02-14 15:36 ` Bryan Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090206115626.GD8723@sirena.org.uk \
--to=broonie@sirena.org.uk \
--cc=alsa-devel@alsa-project.org \
--cc=cliff.cai@analog.com \
--cc=cooloney@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.