From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758354AbZBFO6v (ORCPT ); Fri, 6 Feb 2009 09:58:51 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752467AbZBFO6n (ORCPT ); Fri, 6 Feb 2009 09:58:43 -0500 Received: from mx2.mail.elte.hu ([157.181.151.9]:35581 "EHLO mx2.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753368AbZBFO6m (ORCPT ); Fri, 6 Feb 2009 09:58:42 -0500 Date: Fri, 6 Feb 2009 15:58:06 +0100 From: Ingo Molnar To: Russell King - ARM Linux Cc: Jaswinder Singh Rajput , Linus Torvalds , Tony Luck , Sam Ravnborg , Andrew Morton , hskinnemoen@atmel.com, cooloney@kernel.org, ralf@linux-mips.org, dhowells@redhat.com, matthew@wil.cx, chris@zankel.net, LKML Subject: Re: [git pull -tip] headers_check fixes for other architectures Message-ID: <20090206145806.GI18368@elte.hu> References: <1233385816.17794.16.camel@localhost.localdomain> <12c511ca0902050955x1acb3907jdbfc1d0e6392cb91@mail.gmail.com> <20090205191907.GA27422@elte.hu> <1233886017.3463.26.camel@localhost.localdomain> <20090206022025.GA8317@elte.hu> <1233929922.3209.6.camel@localhost.localdomain> <20090206142134.GA13758@n2100.arm.linux.org.uk> <1233930860.3209.13.camel@localhost.localdomain> <20090206145119.GB13758@n2100.arm.linux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090206145119.GB13758@n2100.arm.linux.org.uk> User-Agent: Mutt/1.5.18 (2008-05-17) X-ELTE-VirusStatus: clean X-ELTE-SpamScore: -1.5 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-1.5 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.2.3 -1.5 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Russell King - ARM Linux wrote: > On Fri, Feb 06, 2009 at 08:04:20PM +0530, Jaswinder Singh Rajput wrote: > > On Fri, 2009-02-06 at 14:21 +0000, Russell King - ARM Linux wrote: > > > On Fri, Feb 06, 2009 at 07:48:42PM +0530, Jaswinder Singh Rajput wrote: > > > > diff --git a/include/linux/types.h b/include/linux/types.h > > > > index 712ca53..c30973a 100644 > > > > --- a/include/linux/types.h > > > > +++ b/include/linux/types.h > > > > @@ -1,6 +1,7 @@ > > > > #ifndef _LINUX_TYPES_H > > > > #define _LINUX_TYPES_H > > > > > > > > +#ifndef __ASSEMBLY__ > > > > #ifdef __KERNEL__ > > > > > > > > #define DECLARE_BITMAP(name,bits) \ > > > > @@ -212,5 +213,5 @@ struct ustat { > > > > }; > > > > > > > > #endif /* __KERNEL__ */ > > > > - > > > > +#endif /* __ASSEMBLY__ */ > > > > #endif /* _LINUX_TYPES_H */ > > > > > > So no point including this file in assembly with this patch - the ifndef > > > disables the entire file. > > > > Truth Table of linux/types.h : > > > > If Assembly then N > > otherwise Y > > > > what your table says. > > If the entire file is not suitable for assembly, don't include the file > in assembly files. Nice and simple, and no need to add additional ifdefs. Well types.h easily gets included in other files though, which might be partially suited for assembly - and have !__ASSEMBLY__ portions that rely on a types.h include. So making this file an invariant in .S files does not sound like a bad idea to me. Is there any downside? Ingo