From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner+w=401wt.eu-S1757268AbZBFPTa@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1757268AbZBFPTa (ORCPT <rfc822;w@1wt.eu>);
	Fri, 6 Feb 2009 10:19:30 -0500
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756010AbZBFPTA
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Fri, 6 Feb 2009 10:19:00 -0500
Received: from marge.padd.com ([99.188.165.110]:35061 "EHLO marge.padd.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1755932AbZBFPS7 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Fri, 6 Feb 2009 10:18:59 -0500
X-Greylist: delayed 612 seconds by postgrey-1.27 at vger.kernel.org; Fri, 06 Feb 2009 10:18:59 EST
Date: Fri, 6 Feb 2009 07:08:58 -0800
From: Pete Wyckoff <pw@padd.com>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: sam@ravnborg.org, akpm@osdl.org, albcamus@gmail.com,
       linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tags: fix config symbols generation
Message-ID: <20090206150858.GA15565@padd.com>
References: <20090129102618.GB4425@x200.localdomain>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20090129102618.GB4425@x200.localdomain>
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

adobriyan@gmail.com wrote on Thu, 29 Jan 2009 13:26 +0300:
> commit 4f628248a578585472e19e4cba2c604643af8c6c aka
> "kbuild: reintroduce ALLSOURCE_ARCHS support for tags/cscope"
> breaks tags generation for Kconfig symbols.
> 
> Steps to reproduce:
> 
> 	make tags
> 	vi -t PROC_FS
> 
> It should jump to 'config PROC_FS' line.
> 
> Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
> ---
> 
>  scripts/tags.sh |    5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> --- a/scripts/tags.sh
> +++ b/scripts/tags.sh
> @@ -76,7 +76,10 @@ all_sources()
>  
>  all_kconfigs()
>  {
> -	find_sources $ALLSOURCE_ARCHS 'Kconfig*'
> +	for arch in $ALLSOURCE_ARCHS; do
> +		find_sources $arch 'Kconfig*'
> +	done
> +	find_other_sources 'Kconfig*'
>  }
>  
>  all_defconfigs()

Yes, this is necessary.  It fixes the problem introduced by
4f628248a578585472e19e4cba2c604643af8c6c (kbuild: reintroduce
ALLSOURCE_ARCHS support for tags/cscope).

Tested-by: Pete Wyckoff <pw@padd.com>